mirror of
https://github.com/maybe-finance/maybe.git
synced 2025-07-23 15:19:38 +02:00
* add kind to transaction model * Basic transfer creator * Fix method naming conflict * Creator form pattern * Remove stale methods * Tweak migration * Remove BaseQuery, write entire query in each class for clarity * Query optimizations * Remove unused exchange rate query lines * Remove temporary cache-warming strategy * Fix test * Update transaction search * Decouple transactions endpoint from IncomeStatement * Clean up transactions controller * Update cursor rules * Cleanup comments, logic in search * Fix totals logic on transactions view * Fix pagination * Optimize search totals query * Default to last 30 days on transactions page if no filters * Decouple transactions list from transfer details * Revert transfer route * Migration reset * Bundle update * Fix matching logic, tests * Remove unused code
138 lines
3.6 KiB
Ruby
138 lines
3.6 KiB
Ruby
class Transfer < ApplicationRecord
|
|
belongs_to :inflow_transaction, class_name: "Transaction"
|
|
belongs_to :outflow_transaction, class_name: "Transaction"
|
|
|
|
enum :status, { pending: "pending", confirmed: "confirmed" }
|
|
|
|
validates :inflow_transaction_id, uniqueness: true
|
|
validates :outflow_transaction_id, uniqueness: true
|
|
|
|
validate :transfer_has_different_accounts
|
|
validate :transfer_has_opposite_amounts
|
|
validate :transfer_within_date_range
|
|
validate :transfer_has_same_family
|
|
|
|
class << self
|
|
def kind_for_account(account)
|
|
if account.loan?
|
|
"loan_payment"
|
|
elsif account.liability?
|
|
"cc_payment"
|
|
else
|
|
"funds_movement"
|
|
end
|
|
end
|
|
end
|
|
|
|
def reject!
|
|
Transfer.transaction do
|
|
RejectedTransfer.find_or_create_by!(inflow_transaction_id: inflow_transaction_id, outflow_transaction_id: outflow_transaction_id)
|
|
destroy!
|
|
end
|
|
end
|
|
|
|
# Once transfer is destroyed, we need to mark the denormalized kind fields on the transactions
|
|
def destroy!
|
|
Transfer.transaction do
|
|
inflow_transaction.update!(kind: "standard")
|
|
outflow_transaction.update!(kind: "standard")
|
|
super
|
|
end
|
|
end
|
|
|
|
def confirm!
|
|
update!(status: "confirmed")
|
|
end
|
|
|
|
def date
|
|
inflow_transaction.entry.date
|
|
end
|
|
|
|
def sync_account_later
|
|
inflow_transaction&.entry&.sync_account_later
|
|
outflow_transaction&.entry&.sync_account_later
|
|
end
|
|
|
|
def to_account
|
|
inflow_transaction&.entry&.account
|
|
end
|
|
|
|
def from_account
|
|
outflow_transaction&.entry&.account
|
|
end
|
|
|
|
def amount_abs
|
|
inflow_transaction&.entry&.amount_money&.abs
|
|
end
|
|
|
|
def name
|
|
acc = to_account
|
|
if payment?
|
|
acc ? "Payment to #{acc.name}" : "Payment"
|
|
else
|
|
acc ? "Transfer to #{acc.name}" : "Transfer"
|
|
end
|
|
end
|
|
|
|
def payment?
|
|
to_account&.liability?
|
|
end
|
|
|
|
def loan_payment?
|
|
outflow_transaction&.kind == "loan_payment"
|
|
end
|
|
|
|
def liability_payment?
|
|
outflow_transaction&.kind == "cc_payment"
|
|
end
|
|
|
|
def regular_transfer?
|
|
outflow_transaction&.kind == "funds_movement"
|
|
end
|
|
|
|
def transfer_type
|
|
return "loan_payment" if loan_payment?
|
|
return "liability_payment" if liability_payment?
|
|
"transfer"
|
|
end
|
|
|
|
def categorizable?
|
|
to_account&.accountable_type == "Loan"
|
|
end
|
|
|
|
private
|
|
def transfer_has_different_accounts
|
|
return unless inflow_transaction&.entry && outflow_transaction&.entry
|
|
errors.add(:base, "Must be from different accounts") if to_account == from_account
|
|
end
|
|
|
|
def transfer_has_same_family
|
|
return unless inflow_transaction&.entry && outflow_transaction&.entry
|
|
errors.add(:base, "Must be from same family") unless to_account&.family == from_account&.family
|
|
end
|
|
|
|
def transfer_has_opposite_amounts
|
|
return unless inflow_transaction&.entry && outflow_transaction&.entry
|
|
|
|
inflow_entry = inflow_transaction.entry
|
|
outflow_entry = outflow_transaction.entry
|
|
|
|
inflow_amount = inflow_entry.amount
|
|
outflow_amount = outflow_entry.amount
|
|
|
|
if inflow_entry.currency == outflow_entry.currency
|
|
# For same currency, amounts must be exactly opposite
|
|
errors.add(:base, "Must have opposite amounts") if inflow_amount + outflow_amount != 0
|
|
else
|
|
# For different currencies, just check the signs are opposite
|
|
errors.add(:base, "Must have opposite amounts") unless inflow_amount.negative? && outflow_amount.positive?
|
|
end
|
|
end
|
|
|
|
def transfer_within_date_range
|
|
return unless inflow_transaction&.entry && outflow_transaction&.entry
|
|
|
|
date_diff = (inflow_transaction.entry.date - outflow_transaction.entry.date).abs
|
|
errors.add(:base, "Must be within 4 days") if date_diff > 4
|
|
end
|
|
end
|