mirror of
https://github.com/maybe-finance/maybe.git
synced 2025-07-19 05:09:38 +02:00
* Initial entryable models * Update transfer and tests * Update transaction controllers and tests * Update sync process to use new entries model * Get dashboard working again * Update transfers, imports, and accounts to use Account::Entry * Update system tests * Consolidate transaction management into entries controller * Add permitted partial key helper * Move account transactions list to entries controller * Delegate transaction entries search * Move transfer relation to entry * Update bulk transaction management flows to use entries * Remove test code * Test fix attempt * Update demo data script * Consolidate remaining transaction partials to entries * Consolidate valuations controller to entries controller * Lint fix * Remove unused files, additional cleanup * Add back valuation creation * Make migrations fully reversible * Stale routes cleanup * Migrations reversible fix * Move types to entryable concern * Fix search when no entries found * Remove more unused code
185 lines
6.2 KiB
Ruby
185 lines
6.2 KiB
Ruby
require "test_helper"
|
|
|
|
class TransactionsControllerTest < ActionDispatch::IntegrationTest
|
|
setup do
|
|
sign_in @user = users(:family_admin)
|
|
@transaction_entry = account_entries(:checking_one)
|
|
@recent_transaction_entries = @user.family.entries.account_transactions.reverse_chronological.limit(20).to_a
|
|
end
|
|
|
|
test "should get new" do
|
|
get new_transaction_url
|
|
assert_response :success
|
|
end
|
|
|
|
test "prefills account_id" do
|
|
get new_transaction_url(account_id: @transaction_entry.account.id)
|
|
assert_response :success
|
|
assert_select "option[selected][value='#{@transaction_entry.account.id}']"
|
|
end
|
|
|
|
test "should create transaction" do
|
|
account = @user.family.accounts.first
|
|
entry_params = {
|
|
account_id: account.id,
|
|
amount: 100.45,
|
|
currency: "USD",
|
|
date: Date.current,
|
|
name: "Test transaction",
|
|
entryable_type: "Account::Transaction",
|
|
entryable_attributes: { category_id: categories(:food_and_drink).id }
|
|
}
|
|
|
|
assert_difference [ "Account::Entry.count", "Account::Transaction.count" ], 1 do
|
|
post transactions_url, params: { account_entry: entry_params }
|
|
end
|
|
|
|
assert_equal entry_params[:amount].to_d, Account::Transaction.order(created_at: :desc).first.entry.amount
|
|
assert_equal "New transaction created successfully", flash[:notice]
|
|
assert_enqueued_with(job: AccountSyncJob)
|
|
assert_redirected_to account_url(account)
|
|
end
|
|
|
|
test "expenses are positive" do
|
|
assert_difference([ "Account::Transaction.count", "Account::Entry.count" ], 1) do
|
|
post transactions_url, params: {
|
|
account_entry: {
|
|
nature: "expense",
|
|
account_id: @transaction_entry.account_id,
|
|
amount: @transaction_entry.amount,
|
|
currency: @transaction_entry.currency,
|
|
date: @transaction_entry.date,
|
|
name: @transaction_entry.name,
|
|
entryable_type: "Account::Transaction",
|
|
entryable_attributes: {}
|
|
}
|
|
}
|
|
end
|
|
|
|
created_entry = Account::Entry.order(created_at: :desc).first
|
|
|
|
assert_redirected_to account_url(@transaction_entry.account)
|
|
assert created_entry.amount.positive?, "Amount should be positive"
|
|
end
|
|
|
|
test "incomes are negative" do
|
|
assert_difference("Account::Transaction.count") do
|
|
post transactions_url, params: {
|
|
account_entry: {
|
|
nature: "income",
|
|
account_id: @transaction_entry.account_id,
|
|
amount: @transaction_entry.amount,
|
|
currency: @transaction_entry.currency,
|
|
date: @transaction_entry.date,
|
|
name: @transaction_entry.name,
|
|
entryable_type: "Account::Transaction",
|
|
entryable_attributes: { category_id: categories(:food_and_drink).id }
|
|
}
|
|
}
|
|
end
|
|
|
|
created_entry = Account::Entry.order(created_at: :desc).first
|
|
|
|
assert_redirected_to account_url(@transaction_entry.account)
|
|
assert created_entry.amount.negative?, "Amount should be negative"
|
|
end
|
|
|
|
test "should get paginated index with most recent transactions first" do
|
|
get transactions_url(per_page: 10)
|
|
assert_response :success
|
|
|
|
@recent_transaction_entries.first(10).each do |transaction|
|
|
assert_dom "#" + dom_id(transaction), count: 1
|
|
end
|
|
end
|
|
|
|
test "transaction count represents filtered total" do
|
|
get transactions_url(per_page: 10)
|
|
assert_dom "#total-transactions", count: 1, text: @user.family.entries.account_transactions.select { |t| t.currency == "USD" }.count.to_s
|
|
|
|
new_transaction = @user.family.accounts.first.entries.create! \
|
|
entryable: Account::Transaction.new,
|
|
name: "Transaction to search for",
|
|
date: Date.current,
|
|
amount: 0,
|
|
currency: "USD"
|
|
|
|
get transactions_url(q: { search: new_transaction.name })
|
|
|
|
# Only finds 1 transaction that matches filter
|
|
assert_dom "#" + dom_id(new_transaction), count: 1
|
|
assert_dom "#total-transactions", count: 1, text: "1"
|
|
end
|
|
|
|
test "can navigate to paginated result" do
|
|
get transactions_url(page: 2, per_page: 10)
|
|
assert_response :success
|
|
|
|
visible_transaction_entries = @recent_transaction_entries[10, 10].reject { |e| e.transfer.present? }
|
|
|
|
visible_transaction_entries.each do |transaction|
|
|
assert_dom "#" + dom_id(transaction), count: 1
|
|
end
|
|
end
|
|
|
|
test "loads last page when page is out of range" do
|
|
user_oldest_transaction_entry = @user.family.entries.account_transactions.chronological.first
|
|
get transactions_url(page: 9999999999)
|
|
|
|
assert_response :success
|
|
assert_dom "#" + dom_id(user_oldest_transaction_entry), count: 1
|
|
end
|
|
|
|
test "can destroy many transactions at once" do
|
|
delete_count = 10
|
|
assert_difference([ "Account::Transaction.count", "Account::Entry.count" ], -delete_count) do
|
|
post bulk_delete_transactions_url, params: {
|
|
bulk_delete: {
|
|
entry_ids: @recent_transaction_entries.first(delete_count).pluck(:id)
|
|
}
|
|
}
|
|
end
|
|
|
|
assert_redirected_to transactions_url
|
|
assert_equal "10 transactions deleted", flash[:notice]
|
|
end
|
|
|
|
test "can update many transactions at once" do
|
|
transactions = @user.family.entries.account_transactions.reverse_chronological.limit(20)
|
|
|
|
transactions.each do |transaction|
|
|
transaction.update! \
|
|
date: Date.current,
|
|
entryable_attributes: {
|
|
id: transaction.account_transaction.id,
|
|
category_id: Category.first.id,
|
|
merchant_id: Merchant.first.id,
|
|
notes: "Starting note"
|
|
}
|
|
end
|
|
|
|
assert_difference [ "Account::Entry.count", "Account::Transaction.count" ], 0 do
|
|
post bulk_update_transactions_url, params: {
|
|
bulk_update: {
|
|
entry_ids: transactions.map(&:id),
|
|
date: 1.day.ago.to_date,
|
|
category_id: Category.second.id,
|
|
merchant_id: Merchant.second.id,
|
|
notes: "Updated note"
|
|
}
|
|
}
|
|
end
|
|
|
|
assert_redirected_to transactions_url
|
|
assert_equal "#{transactions.count} transactions updated", flash[:notice]
|
|
|
|
transactions.reload
|
|
|
|
transactions.each do |transaction|
|
|
assert_equal 1.day.ago.to_date, transaction.date
|
|
assert_equal Category.second, transaction.account_transaction.category
|
|
assert_equal Merchant.second, transaction.account_transaction.merchant
|
|
assert_equal "Updated note", transaction.account_transaction.notes
|
|
end
|
|
end
|
|
end
|