mirror of
https://github.com/maybe-finance/maybe.git
synced 2025-07-19 05:09:38 +02:00
d75be2282b
Since the very first 0.1.0-alpha.1 release, we've been moving quickly to add new features to the Maybe app. In doing so, some parts of the codebase have become outdated, unnecessary, or overly-complex as a natural result of this feature prioritization. Now that "core" Maybe is complete, we're moving into a second phase of development where we'll be working hard to improve the accuracy of existing features and build additional features on top of "core". This PR is a quick overhaul of the existing codebase aimed to: - Establish the brand new and simplified dashboard view (pictured above) - Establish and move towards the conventions introduced in Cursor rules and project design overview #1788 - Consolidate layouts and improve the performance of layout queries - Organize the core models of the Maybe domain (i.e. Account::Entry, Account::Transaction, etc.) and break out specific traits of each model into dedicated concerns for better readability - Remove stale / dead code from codebase - Remove overly complex code paths in favor of simpler ones
65 lines
1.6 KiB
Ruby
65 lines
1.6 KiB
Ruby
class Account::Holding < ApplicationRecord
|
|
include Monetizable
|
|
|
|
monetize :amount
|
|
|
|
belongs_to :account
|
|
belongs_to :security
|
|
|
|
validates :qty, :currency, :date, :price, :amount, presence: true
|
|
validates :qty, :price, :amount, numericality: { greater_than_or_equal_to: 0 }
|
|
|
|
scope :chronological, -> { order(:date) }
|
|
scope :for, ->(security) { where(security_id: security).order(:date) }
|
|
|
|
delegate :ticker, to: :security
|
|
|
|
def name
|
|
security.name || ticker
|
|
end
|
|
|
|
def weight
|
|
return nil unless amount
|
|
return 0 if amount.zero?
|
|
|
|
account.balance.zero? ? 1 : amount / account.balance * 100
|
|
end
|
|
|
|
# Basic approximation of cost-basis
|
|
def avg_cost
|
|
avg_cost = account.entries.account_trades
|
|
.joins("INNER JOIN account_trades ON account_trades.id = account_entries.entryable_id")
|
|
.where("account_trades.security_id = ? AND account_trades.qty > 0 AND account_entries.date <= ?", security.id, date)
|
|
.average(:price)
|
|
|
|
Money.new(avg_cost || price, currency)
|
|
end
|
|
|
|
def trend
|
|
@trend ||= calculate_trend
|
|
end
|
|
|
|
def trades
|
|
account.entries.where(entryable: account.trades.where(security: security)).reverse_chronological
|
|
end
|
|
|
|
def destroy_holding_and_entries!
|
|
transaction do
|
|
account.entries.where(entryable: account.trades.where(security: security)).destroy_all
|
|
destroy
|
|
end
|
|
|
|
account.sync_later
|
|
end
|
|
|
|
private
|
|
def calculate_trend
|
|
return nil unless amount_money
|
|
|
|
start_amount = qty * avg_cost
|
|
|
|
Trend.new \
|
|
current: amount_money,
|
|
previous: start_amount
|
|
end
|
|
end
|