mirror of
https://github.com/maybe-finance/maybe.git
synced 2025-07-25 08:09:38 +02:00
d75be2282b
Since the very first 0.1.0-alpha.1 release, we've been moving quickly to add new features to the Maybe app. In doing so, some parts of the codebase have become outdated, unnecessary, or overly-complex as a natural result of this feature prioritization. Now that "core" Maybe is complete, we're moving into a second phase of development where we'll be working hard to improve the accuracy of existing features and build additional features on top of "core". This PR is a quick overhaul of the existing codebase aimed to: - Establish the brand new and simplified dashboard view (pictured above) - Establish and move towards the conventions introduced in Cursor rules and project design overview #1788 - Consolidate layouts and improve the performance of layout queries - Organize the core models of the Maybe domain (i.e. Account::Entry, Account::Transaction, etc.) and break out specific traits of each model into dedicated concerns for better readability - Remove stale / dead code from codebase - Remove overly complex code paths in favor of simpler ones
87 lines
2.8 KiB
Ruby
87 lines
2.8 KiB
Ruby
require "test_helper"
|
|
|
|
class Account::EntryTest < ActiveSupport::TestCase
|
|
include Account::EntriesTestHelper
|
|
|
|
setup do
|
|
@entry = account_entries :transaction
|
|
end
|
|
|
|
test "entry cannot be older than 10 years ago" do
|
|
assert_raises ActiveRecord::RecordInvalid do
|
|
@entry.update! date: 50.years.ago.to_date
|
|
end
|
|
end
|
|
|
|
test "valuations cannot have more than one entry per day" do
|
|
existing_valuation = account_entries :valuation
|
|
|
|
new_valuation = Account::Entry.new \
|
|
entryable: Account::Valuation.new,
|
|
account: existing_valuation.account,
|
|
date: existing_valuation.date, # invalid
|
|
currency: existing_valuation.currency,
|
|
amount: existing_valuation.amount
|
|
|
|
assert new_valuation.invalid?
|
|
end
|
|
|
|
test "triggers sync with correct start date when transaction is set to prior date" do
|
|
prior_date = @entry.date - 1
|
|
@entry.update! date: prior_date
|
|
|
|
@entry.account.expects(:sync_later).with(start_date: prior_date)
|
|
@entry.sync_account_later
|
|
end
|
|
|
|
test "triggers sync with correct start date when transaction is set to future date" do
|
|
prior_date = @entry.date
|
|
@entry.update! date: @entry.date + 1
|
|
|
|
@entry.account.expects(:sync_later).with(start_date: prior_date)
|
|
@entry.sync_account_later
|
|
end
|
|
|
|
test "triggers sync with correct start date when transaction deleted" do
|
|
@entry.destroy!
|
|
|
|
@entry.account.expects(:sync_later).with(start_date: nil)
|
|
@entry.sync_account_later
|
|
end
|
|
|
|
test "can search entries" do
|
|
family = families(:empty)
|
|
account = family.accounts.create! name: "Test", balance: 0, currency: "USD", accountable: Depository.new
|
|
category = family.categories.first
|
|
merchant = family.merchants.first
|
|
|
|
create_transaction(account: account, name: "a transaction")
|
|
create_transaction(account: account, name: "ignored")
|
|
create_transaction(account: account, name: "third transaction", category: category, merchant: merchant)
|
|
|
|
params = { search: "a" }
|
|
|
|
assert_equal 2, family.entries.search(params).size
|
|
|
|
params = { search: "%" }
|
|
assert_equal 0, family.entries.search(params).size
|
|
end
|
|
|
|
test "active scope only returns entries from active accounts" do
|
|
# Create transactions for all account types
|
|
active_transaction = create_transaction(account: accounts(:depository), name: "Active transaction")
|
|
inactive_transaction = create_transaction(account: accounts(:credit_card), name: "Inactive transaction")
|
|
|
|
# Update account statuses
|
|
accounts(:credit_card).update!(is_active: false)
|
|
|
|
# Test the scope
|
|
active_entries = Account::Entry.active
|
|
|
|
# Should include entry from active account
|
|
assert_includes active_entries, active_transaction
|
|
|
|
# Should not include entry from inactive account
|
|
assert_not_includes active_entries, inactive_transaction
|
|
end
|
|
end
|