From 1bc65be955a32112baa1517dd5d95e267f9abb34 Mon Sep 17 00:00:00 2001 From: YeoKyung Yoon Date: Fri, 9 Sep 2022 20:25:46 +0900 Subject: [PATCH 1/2] feat: hide-sidebar-content-on-mobile (#241) --- src/frontend/js/modules/sidebar.js | 4 ++-- src/frontend/styles/components/sidebar.pcss | 7 ++++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/frontend/js/modules/sidebar.js b/src/frontend/js/modules/sidebar.js index 46d9782..37db55e 100644 --- a/src/frontend/js/modules/sidebar.js +++ b/src/frontend/js/modules/sidebar.js @@ -36,7 +36,7 @@ export default class Sidebar { sidebarCollapsed: 'docs-sidebar--collapsed', sidebarAnimated: 'docs-sidebar--animated', sidebarContent: 'docs-sidebar__content', - sidebarContentHidden: 'docs-sidebar__content--hidden', + sidebarContentVisible: 'docs-sidebar__content--visible', sidebarContentInvisible: 'docs-sidebar__content--invisible', }; } @@ -182,7 +182,7 @@ export default class Sidebar { * @returns {void} */ toggleSidebar() { - this.nodes.sidebarContent.classList.toggle(Sidebar.CSS.sidebarContentHidden); + this.nodes.sidebarContent.classList.toggle(Sidebar.CSS.sidebarContentVisible); } /** diff --git a/src/frontend/styles/components/sidebar.pcss b/src/frontend/styles/components/sidebar.pcss index 5ccbdc3..bd2da28 100644 --- a/src/frontend/styles/components/sidebar.pcss +++ b/src/frontend/styles/components/sidebar.pcss @@ -50,12 +50,13 @@ padding-bottom: 0; } - @media (--mobile){ + @media (--mobile) { margin: 0 -8px; + display: none; } - &--hidden { - display: none; + &--visible { + display: block; } &--invisible { From c71b3c273a1aee2ccfdfd3fcbe0c27a9db4a1f3d Mon Sep 17 00:00:00 2001 From: Yeokyung Yoon Date: Fri, 9 Sep 2022 21:39:23 +0900 Subject: [PATCH 2/2] fix: release writing header --- src/frontend/styles/components/writing.pcss | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/frontend/styles/components/writing.pcss b/src/frontend/styles/components/writing.pcss index 3aef283..133c56c 100644 --- a/src/frontend/styles/components/writing.pcss +++ b/src/frontend/styles/components/writing.pcss @@ -1,6 +1,4 @@ .writing-header { - position: sticky; - top: 0; padding: 15px 0; margin-top: calc(-1 * var(--layout-padding-vertical)); background: #fff;