Reduce cloned space permissions copy

Removed unnecessary results from SQL.

domain/permission/mysql/store.go

@@ -117,13 +117,18 @@ func (s Scope) GetSpacePermissions(ctx domain.RequestContext, spaceID string) (r
 
 	err = s.Runtime.Db.Select(&r, `
 		SELECT id, orgid, who, whoid, action, scope, location, refid
-			FROM permission WHERE orgid=? AND location='space' AND refid=? AND who='user'
+			FROM permission WHERE orgid=? AND location='space' AND refid=?`,
-		UNION ALL
+		ctx.OrgID, spaceID)
-		SELECT p.id, p.orgid, p.who, p.whoid, p.action, p.scope, p.location, p.refid
+
-			FROM permission p
+	// err = s.Runtime.Db.Select(&r, `
-			LEFT JOIN rolemember r ON p.whoid=r.roleid
+	// 	SELECT id, orgid, who, whoid, action, scope, location, refid
-			WHERE p.orgid=? AND p.location='space' AND p.refid=? AND p.who='role'`,
+	// 		FROM permission WHERE orgid=? AND location='space' AND refid=? AND who='user'
-		ctx.OrgID, spaceID, ctx.OrgID, spaceID)
+	// 	UNION ALL
+	// 	SELECT p.id, p.orgid, p.who, p.whoid, p.action, p.scope, p.location, p.refid
+	// 		FROM permission p
+	// 		LEFT JOIN rolemember r ON p.whoid=r.roleid
+	// 		WHERE p.orgid=? AND p.location='space' AND p.refid=? AND p.who='role'`,
+	// 	ctx.OrgID, spaceID, ctx.OrgID, spaceID)
 
 	if err == sql.ErrNoRows {
 		err = nil

domain/space/endpoint.go

@@ -155,15 +155,15 @@ func (h *Handler) Add(w http.ResponseWriter, r *http.Request) {
 			return
 		}
 
-		spCloneRoles, err := h.Store.Permission.GetSpacePermissions(ctx, model.CloneID)
-		if err != nil {
-			ctx.Transaction.Rollback()
-			response.WriteServerError(w, method, err)
-			h.Runtime.Log.Error(method, err)
-			return
-		}
-
 		if model.CopyPermission {
+			spCloneRoles, err := h.Store.Permission.GetSpacePermissions(ctx, model.CloneID)
+			if err != nil {
+				ctx.Transaction.Rollback()
+				response.WriteServerError(w, method, err)
+				h.Runtime.Log.Error(method, err)
+				return
+			}
+
 			for _, r := range spCloneRoles {
 				r.RefID = sp.RefID