Docker/documize
Docker/documize
1
0
Fork 0
mirror of https://github.com/documize/community.git synced 2025-07-20 21:59:42 +02:00
Code Releases Activity

Correctly unsubscribe from JS event listeners

Browse source
This commit is contained in:
sauls8t 2019-01-24 15:27:21 +00:00
parent 9fd002b5da
commit 1e217274c6
3 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

2
gui/app/components/document/sidebar-toc.js
View file

@ -58,7 +58,7 @@ export default Component.extend({
willDestroyElement() { willDestroyElement() {
this._super(...arguments); this._super(...arguments);
this.eventBus.unsubscribe('documentPageAdded'); this.eventBus.unsubscribe('documentPageAdded', this, 'onDocumentPageAdded');
}, },
onDocumentPageAdded(pageId) { onDocumentPageAdded(pageId) {

4
gui/app/components/layout/master-sidebar.js
View file

@ -79,8 +79,8 @@ export default Component.extend(Modals, {
willDestroyElement() { willDestroyElement() {
this._super(...arguments); this._super(...arguments);
this.eventBus.unsubscribe('notifyUser'); this.eventBus.unsubscribe('notifyUser', this, 'processNotification');
this.eventBus.unsubscribe('pinChange'); this.eventBus.unsubscribe('pinChange', this, 'setupPins');
iziToast.destroy(); iziToast.destroy();
}, },

20
gui/app/services/event-bus.js
View file

@ -13,18 +13,18 @@ import Evented from '@ember/object/evented';
import Service from '@ember/service'; import Service from '@ember/service';
export default Service.extend(Evented, { export default Service.extend(Evented, {
init() { // init() {
this._super(...arguments); // this._super(...arguments);
let _this = this; // let _this = this;
window.addEventListener("scroll", _.throttle(function() { // window.addEventListener("scroll", _.throttle(function() {
_this.publish('scrolled', null); // _this.publish('scrolled', null);
}, 100)); // }, 100));
window.addEventListener("resize", _.debounce(function() { // window.addEventListener("resize", _.debounce(function() {
_this.publish('resized', null); // _this.publish('resized', null);
}, 100)); // }, 100));
}, // },
publish: function() { publish: function() {
return this.trigger.apply(this, arguments); return this.trigger.apply(this, arguments);