Docker/documize
Docker/documize
1
0
Fork 0
mirror of https://github.com/documize/community.git synced 2025-07-24 23:59:47 +02:00
Code Releases Activity

Improve semver unit test

Browse source 
Now handles empty database scenario
This commit is contained in:
Harvey Kandola 2018-03-23 13:01:25 +00:00
parent c31711c130
commit 8077dd939a
4 changed files with 675 additions and 668 deletions
Download patch file Download diff file Expand all files Collapse all files

1334
embed/bindata_assetfs.go
View file

File diff suppressed because one or more lines are too long

1
gui/app/services/category.js
View file

@ -177,7 +177,6 @@ export default BaseService.extend({
membership: [], membership: [],
summary: [] summary: []
}; };
if (is.not.array(response)) response = [];
let cats = response.category.map((obj) => { let cats = response.category.map((obj) => {
let data = this.get('store').normalize('category', obj); let data = this.get('store').normalize('category', obj);

3
gui/app/utils/misc.js
View file

@ -71,6 +71,9 @@ function isNewVersion(v1, v2, compareRevision) {
v1 = v1.trim().toLowerCase(); v1 = v1.trim().toLowerCase();
v2 = v2.trim().toLowerCase(); v2 = v2.trim().toLowerCase();
// Handle edge case of no prior version.
if (v1 === '' && v2 !== '') return true;
// Format expected is "1.2.3". // Format expected is "1.2.3".
let v1parts = v1.split('.'); let v1parts = v1.split('.');
let v2parts = v2.split('.'); let v2parts = v2.split('.');

5
gui/tests/unit/utils/misc-test.js
View file

@ -21,6 +21,11 @@ module('Unit | Utility | Version', function (hooks) {
assert.equal(result, false, 'version cleaned and same'); assert.equal(result, false, 'version cleaned and same');
}); });
test('version migration', function (assert) {
let result = misc.isNewVersion('', 'v1.0.0', false);
assert.equal(result, true, 'version migration');
});
test('version same', function (assert) { test('version same', function (assert) {
let result = misc.isNewVersion('v1.0.0', 'v1.0.0', false); let result = misc.isNewVersion('v1.0.0', 'v1.0.0', false);
assert.equal(result, false, 'version same'); assert.equal(result, false, 'version same');