Fix regression for downloading certain binary attachments

README.md

@@ -13,9 +13,9 @@ All you need to provide is PostgreSQL, Microsoft SQL Server or any MySQL variant
 
 ## Latest Release
 
-[Community Edition: v3.4.2](https://github.com/documize/community/releases)
+[Community Edition: v3.4.3](https://github.com/documize/community/releases)
 
-[Enterprise Edition: v3.4.2](https://www.documize.com/downloads)
+[Enterprise Edition: v3.4.3](https://www.documize.com/downloads)
 
 > *We provide frequent product updates for both cloud and self-hosted customers.*
 >

domain/attachment/endpoint.go

@@ -180,7 +180,7 @@ func (h *Handler) Download(w http.ResponseWriter, r *http.Request) {
 
 	dataSize := len(a.Data)
 
-	w.WriteHeader(http.StatusOK)
+	// w.WriteHeader(http.StatusOK)
 	w.Header().Set("Content-Type", typ)
 	w.Header().Set("Content-Disposition", `Attachment; filename="`+a.Filename+`" ; `+`filename*="`+a.Filename+`"`)
 	if dataSize != 0 {

domain/space/endpoint.go

@@ -518,7 +518,7 @@ func (h *Handler) Update(w http.ResponseWriter, r *http.Request) {
 	sp.RefID = spaceID
 
 	// Check permissions (either Documize admin OR space owner/manager).
-	canManage := perm.CanViewSpace(ctx, *h.Store, spaceID)
+	canManage := perm.CanManageSpace(ctx, *h.Store, spaceID)
 	if !canManage && !ctx.Administrator {
 		response.WriteForbiddenError(w)
 		return

edition/community.go

@@ -41,8 +41,8 @@ func main() {
 	rt.Product = domain.Product{}
 	rt.Product.Major = "3"
 	rt.Product.Minor = "4"
-	rt.Product.Patch = "2"
-	rt.Product.Revision = "191108120152"
+	rt.Product.Patch = "3"
+	rt.Product.Revision = "191114171637"
 	rt.Product.Version = fmt.Sprintf("%s.%s.%s", rt.Product.Major, rt.Product.Minor, rt.Product.Patch)
 	rt.Product.Edition = domain.CommunityEdition
 	rt.Product.Title = fmt.Sprintf("%s Edition", rt.Product.Edition)

gui/package.json

@@ -1,6 +1,6 @@
 {
   "name": "documize",
-  "version": "3.4.2",
+  "version": "3.4.3",
   "description": "Documize is the Integrated Document Environment (IDE)",
   "repository": "",
   "license": "AGPL",