Docker/documize
Docker/documize
1
0
Fork 0
mirror of https://github.com/documize/community.git synced 2025-07-23 07:09:43 +02:00
Code Releases Activity

Write HTTP headers before body write

Browse source
This commit is contained in:
sauls8t 2019-11-08 10:40:10 +00:00
parent 7954f4b976
commit ad361c22ba
2 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
domain/attachment/endpoint.go
View file

@ -180,6 +180,7 @@ func (h *Handler) Download(w http.ResponseWriter, r *http.Request) {
dataSize := len(a.Data) dataSize := len(a.Data)
w.WriteHeader(http.StatusOK)
w.Header().Set("Content-Type", typ) w.Header().Set("Content-Type", typ)
w.Header().Set("Content-Disposition", `Attachment; filename="`+a.Filename+`" ; `+`filename*="`+a.Filename+`"`) w.Header().Set("Content-Disposition", `Attachment; filename="`+a.Filename+`" ; `+`filename*="`+a.Filename+`"`)
if dataSize != 0 { if dataSize != 0 {
@ -191,7 +192,6 @@ func (h *Handler) Download(w http.ResponseWriter, r *http.Request) {
h.Runtime.Log.Error("write attachment", err) h.Runtime.Log.Error("write attachment", err)
return return
} }
w.WriteHeader(http.StatusOK)
h.Store.Audit.Record(ctx, audit.EventTypeAttachmentDownload) h.Store.Audit.Record(ctx, audit.EventTypeAttachmentDownload)
} }

3
domain/backup/endpoint.go
View file

@ -124,6 +124,7 @@ func (h *Handler) Backup(w http.ResponseWriter, r *http.Request) {
// instead of parsing 'Content-Disposition' header. // instead of parsing 'Content-Disposition' header.
// This HTTP header is CORS white-listed. // This HTTP header is CORS white-listed.
w.Header().Set("x-documize-filename", filename) w.Header().Set("x-documize-filename", filename)
w.WriteHeader(http.StatusOK)
// Write backup to response stream. // Write backup to response stream.
x, err := w.Write(bk) x, err := w.Write(bk)
@ -140,8 +141,6 @@ func (h *Handler) Backup(w http.ResponseWriter, r *http.Request) {
if !spec.Retain { if !spec.Retain {
os.Remove(filename) os.Remove(filename)
} }
w.WriteHeader(http.StatusOK)
} }
// Restore receives ZIP file for restore operation. // Restore receives ZIP file for restore operation.