Docker/documize
Docker/documize
1
0
Fork 0
mirror of https://github.com/documize/community.git synced 2025-07-19 21:29:42 +02:00
Code Releases Activity

Record search history only for share spaces

Browse source
This commit is contained in:
McMatts 2018-04-05 14:21:55 +01:00
parent 274b77cb8f
commit c29426f2d7
1 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
domain/document/endpoint.go
View file

@ -439,6 +439,7 @@ func (h *Handler) SearchDocuments(w http.ResponseWriter, r *http.Request) {
} }
// Record search request once per document. // Record search request once per document.
// But only if document is partof shared space at the time of the search.
func (h *Handler) recordSearchActivity(ctx domain.RequestContext, q []search.QueryResult, keywords string) { func (h *Handler) recordSearchActivity(ctx domain.RequestContext, q []search.QueryResult, keywords string) {
method := "recordSearchActivity" method := "recordSearchActivity"
var err error var err error
@ -451,6 +452,16 @@ func (h *Handler) recordSearchActivity(ctx domain.RequestContext, q []search.Que
} }
for i := range q { for i := range q {
// Empty space ID usually signals private document
// hence search activity should not be visible to others.
if len(q[i].SpaceID) == 0 {
continue
}
sp, err := h.Store.Space.Get(ctx, q[i].SpaceID)
if err != nil || len(sp.RefID) == 0 || sp.Type == space.ScopePrivate {
continue
}
if _, isExisting := prev[q[i].DocumentID]; !isExisting { if _, isExisting := prev[q[i].DocumentID]; !isExisting {
err = h.Store.Activity.RecordUserActivity(ctx, activity.UserActivity{ err = h.Store.Activity.RecordUserActivity(ctx, activity.UserActivity{
LabelID: q[i].SpaceID, LabelID: q[i].SpaceID,
@ -466,7 +477,6 @@ func (h *Handler) recordSearchActivity(ctx domain.RequestContext, q []search.Que
prev[q[i].DocumentID] = true prev[q[i].DocumentID] = true
} }
} }
ctx.Transaction.Commit() ctx.Transaction.Commit()