From c4c95a9d248cd182caef35eb6e2dc4f66638837c Mon Sep 17 00:00:00 2001
From: Harvey Kandola <harvey@documize.com>
Date: Mon, 18 Sep 2017 13:50:44 +0100
Subject: [PATCH] revised calc for space type

---
 domain/space/endpoint.go                      | 9 +++++----
 gui/app/components/folder/permission-admin.js | 2 --
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/domain/space/endpoint.go b/domain/space/endpoint.go
index 2e000a9b..a77c3b25 100644
--- a/domain/space/endpoint.go
+++ b/domain/space/endpoint.go
@@ -641,12 +641,13 @@ func (h *Handler) SetPermissions(w http.ResponseWriter, r *http.Request) {
 			me = true
 		}
 
-		if len(perm.UserID) == 0 {
-			hasEveryoneRole = true
-		}
-
 		// Only persist if there is a role!
 		if space.HasAnyPermission(perm) {
+			// identify publically shared spaces
+			if len(perm.UserID) == 0 {
+				hasEveryoneRole = true
+			}
+
 			r := space.EncodeUserPermissions(perm)
 
 			for _, p := range r {
diff --git a/gui/app/components/folder/permission-admin.js b/gui/app/components/folder/permission-admin.js
index f0dcae44..847a1b13 100644
--- a/gui/app/components/folder/permission-admin.js
+++ b/gui/app/components/folder/permission-admin.js
@@ -120,8 +120,6 @@ export default Ember.Component.extend(NotifierMixin, {
 					this.showNotification('Marked space as private');
 				}
 			}
-
-			// this.get('folderService').save(folder).then(function () {});
 		}
 	}
 });