2023-09-15 20:41:08 +02:00
|
|
|
# This file describes the expected reviewers for a PR based on the changed
|
|
|
|
# files. Unlike what the name of the file suggests they don't own the code, but
|
|
|
|
# merely have a good understanding of that area of the codebase and therefore
|
|
|
|
# are usually suited as a reviewer.
|
|
|
|
|
|
|
|
|
|
|
|
# Please mind the alphabetic order of reviewers.
|
|
|
|
|
|
|
|
# Files related to frontend development.
|
|
|
|
|
|
|
|
# Javascript and CSS code.
|
2025-05-05 14:57:27 +00:00
|
|
|
web_src/.* @beowulf @gusted
|
feat(ui): redesign user profile actions layout (#7906)
Related: https://codeberg.org/forgejo/forgejo/pulls/3950#issue-785253, https://codeberg.org/forgejo/forgejo/pulls/3950#issuecomment-1998551.
## Links in dropdown
* move _admin only_ User details link here, give it always-visible text
* add new _self only_ Edit profile link here
* move RSS feed link here
* add new Atom feed link here, previously unadvertised
* add new SSH keys link here (`.keys`), previously unadvertised
* add new GPG keys link here (`.gpg`), previously unadvertised
* move Block/Unblock button here
* move Report abuse link here
If primary action is available (Follow/Unfollow), dropdown with more actions goes after it. If not, it is in line with followers, in place where RSS feed button used to be.
## New dropdown
Related: https://codeberg.org/forgejo/design/issues/23, https://codeberg.org/forgejo/forgejo/issues/3853, https://codeberg.org/0ko/forgejo/issues/2.
Implemented a new dropdown: noJS-usable, JS-enhanced for better keyboard navigation and a11y.
Styling is mostly same as the existing ones have, but row density depends on `@media` pointer type.
My choice of CSS properties have been influenced of these:
* https://github.com/picocss/pico/commit/72a3adb16b2f3248b456da823502f166510720a0
* https://github.com/picocss/pico/commit/51dd2293cab8d77cf13fc2c32b6053ffa654bc56
Inspired-by: KiranMantha <kiranv.mantha@gmail.com>
Inspired-by: Lucas Larroche <lucas@larroche.com>
Co-authored-by: Beowulf <beowulf@beocode.eu>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7906
Reviewed-by: Otto <otto@codeberg.org>
Reviewed-by: Beowulf <beowulf@beocode.eu>
Co-authored-by: 0ko <0ko@noreply.codeberg.org>
Co-committed-by: 0ko <0ko@noreply.codeberg.org>
2025-06-24 14:16:51 +02:00
|
|
|
web_src/css/.* @0ko
|
2023-09-15 20:41:08 +02:00
|
|
|
|
|
|
|
# HTML templates used by the backend.
|
2025-05-05 14:57:27 +00:00
|
|
|
templates/.* @beowulf @gusted
|
2024-04-25 15:08:47 +02:00
|
|
|
## the issue sidebar was touched by fnetx
|
|
|
|
templates/repo/issue/view_content/sidebar.* @fnetx
|
2023-09-15 20:41:08 +02:00
|
|
|
|
2024-10-03 20:29:36 +02:00
|
|
|
# Playwright tests
|
|
|
|
tests/e2e/.* @fnetx
|
|
|
|
|
2023-09-15 20:41:08 +02:00
|
|
|
# Files related to Go development.
|
|
|
|
|
|
|
|
# The modules usually don't require much knowledge about Forgejo and could
|
|
|
|
# be reviewed by Go developers.
|
2024-08-20 08:24:48 +02:00
|
|
|
modules/.* @gusted
|
2023-09-15 20:41:08 +02:00
|
|
|
|
|
|
|
# Models has code related to SQL queries, general database knowledge and XORM.
|
2024-08-20 08:24:48 +02:00
|
|
|
models/.* @gusted
|
2023-09-15 20:41:08 +02:00
|
|
|
|
|
|
|
# The routers directory contains the most amount code that requires a good grasp
|
|
|
|
# of how Forgejo comes together. It's tedious to write good integration testing
|
|
|
|
# for code that lives in here.
|
2024-08-20 08:24:48 +02:00
|
|
|
routers/.* @gusted
|
2024-04-05 10:53:39 +00:00
|
|
|
|
2025-01-26 07:37:50 +00:00
|
|
|
# Let locale changes be checked by the translation team.
|
|
|
|
options/locale/.* @0ko
|
|
|
|
options/locale_next/.* @0ko
|
2024-04-05 10:53:39 +00:00
|
|
|
|
|
|
|
# Personal interest
|
|
|
|
.*/webhook.* @oliverpool
|