From 09c9108a354b5dc339406d26173ef9df64500879 Mon Sep 17 00:00:00 2001 From: Michael Kriese Date: Wed, 16 Jul 2025 18:07:19 +0200 Subject: [PATCH] fix(packages): skip another stack frame from logging (#8530) Log the right stack frame line. We currently always show the `apiError` method call. related to #8529 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8530 Reviewed-by: Gusted Co-authored-by: Michael Kriese Co-committed-by: Michael Kriese --- routers/api/packages/helper/helper.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/routers/api/packages/helper/helper.go b/routers/api/packages/helper/helper.go index f9b91d9a09..47d1f18623 100644 --- a/routers/api/packages/helper/helper.go +++ b/routers/api/packages/helper/helper.go @@ -25,7 +25,8 @@ func LogAndProcessError(ctx *context.Context, status int, obj any, cb func(strin message = fmt.Sprintf("%s", obj) } if status == http.StatusInternalServerError { - log.ErrorWithSkip(1, message) + // LogAndProcessError is always wrapped in a `apiError` call, so we need to skip two frames + log.ErrorWithSkip(2, message) if setting.IsProd && (ctx.Doer == nil || !ctx.Doer.IsAdmin) { message = ""