From 161924abf830de48cf58dfb60addbb56287399b2 Mon Sep 17 00:00:00 2001 From: Earl Warren Date: Fri, 30 May 2025 13:01:08 +0200 Subject: [PATCH] chore(cleanup): suppress non actionable XORM warnings (#8021) The following will trigger a XORM warning: ``` type Repository struct { ID int64 `xorm:"pk autoincr"` Topics []string `xorm:"TEXT JSON NOT NULL"` } ``` that looks like: ``` [W] Table repository Column topics db default is '', struct default is ``` it cannot be resolved because: - SQLite requires a default when there is a NOT NULL - MySQL forbids a default for TEXT Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8021 Reviewed-by: Gusted Co-authored-by: Earl Warren Co-committed-by: Earl Warren --- models/db/log.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/models/db/log.go b/models/db/log.go index b94af8e39c..387709cc50 100644 --- a/models/db/log.go +++ b/models/db/log.go @@ -69,6 +69,9 @@ func (l *XORMLogBridge) Warn(v ...any) { // Warnf show warning log func (l *XORMLogBridge) Warnf(format string, v ...any) { + if format == "Table %s Column %s db default is %s, struct default is %s" || format == "Table %s Column %s db nullable is %v, struct nullable is %v" { + return + } l.Log(stackLevel, log.WARN, format, v...) }