mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2025-07-18 17:19:41 +02:00
13b560c191
For the mailer and incoming_mailer config, allow passwords to be read from a file. Add `_URI` config values and use the existing `loadSecret` function to do this. Resolves https://codeberg.org/forgejo/forgejo/issues/8113 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8116 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Reviewed-by: oliverpool <oliverpool@noreply.codeberg.org> Co-authored-by: fruzitent <fruzit@gmail.com> Co-committed-by: fruzitent <fruzit@gmail.com>
92 lines
2.1 KiB
Go
92 lines
2.1 KiB
Go
// Copyright 2024 The Forgejo Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package setting
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_loadIncomingEmailFrom(t *testing.T) {
|
|
makeBaseConfig := func() (ConfigProvider, ConfigSection) {
|
|
cfg, _ := NewConfigProviderFromData("")
|
|
sec := cfg.Section("email.incoming")
|
|
sec.NewKey("ENABLED", "true")
|
|
sec.NewKey("REPLY_TO_ADDRESS", "forge+%{token}@example.com")
|
|
|
|
return cfg, sec
|
|
}
|
|
resetIncomingEmailPort := func() func() {
|
|
return func() {
|
|
IncomingEmail.Port = 0
|
|
}
|
|
}
|
|
|
|
t.Run("aliases", func(t *testing.T) {
|
|
cfg, sec := makeBaseConfig()
|
|
sec.NewKey("USER", "jane.doe@example.com")
|
|
sec.NewKey("PASSWD", "y0u'll n3v3r gUess th1S!!1")
|
|
|
|
loadIncomingEmailFrom(cfg)
|
|
|
|
assert.Equal(t, "jane.doe@example.com", IncomingEmail.Username)
|
|
assert.Equal(t, "y0u'll n3v3r gUess th1S!!1", IncomingEmail.Password)
|
|
})
|
|
|
|
t.Run("Secrets", func(t *testing.T) {
|
|
uri := filepath.Join(t.TempDir(), "email_incoming_password")
|
|
|
|
if err := os.WriteFile(uri, []byte("th1S gUess n3v3r y0u'll!!1"), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
cfg, sec := makeBaseConfig()
|
|
sec.NewKey("PASSWORD_URI", "file:"+uri)
|
|
|
|
IncomingEmail.Password = ""
|
|
loadIncomingEmailFrom(cfg)
|
|
|
|
assert.Equal(t, "th1S gUess n3v3r y0u'll!!1", IncomingEmail.Password)
|
|
})
|
|
|
|
t.Run("Port settings", func(t *testing.T) {
|
|
t.Run("no port, no tls", func(t *testing.T) {
|
|
defer resetIncomingEmailPort()()
|
|
cfg, sec := makeBaseConfig()
|
|
|
|
// False is the default, but we test it explicitly.
|
|
sec.NewKey("USE_TLS", "false")
|
|
|
|
loadIncomingEmailFrom(cfg)
|
|
|
|
assert.Equal(t, 143, IncomingEmail.Port)
|
|
})
|
|
|
|
t.Run("no port, with tls", func(t *testing.T) {
|
|
defer resetIncomingEmailPort()()
|
|
cfg, sec := makeBaseConfig()
|
|
|
|
sec.NewKey("USE_TLS", "true")
|
|
|
|
loadIncomingEmailFrom(cfg)
|
|
|
|
assert.Equal(t, 993, IncomingEmail.Port)
|
|
})
|
|
|
|
t.Run("port overrides tls", func(t *testing.T) {
|
|
defer resetIncomingEmailPort()()
|
|
cfg, sec := makeBaseConfig()
|
|
|
|
sec.NewKey("PORT", "1993")
|
|
sec.NewKey("USE_TLS", "true")
|
|
|
|
loadIncomingEmailFrom(cfg)
|
|
|
|
assert.Equal(t, 1993, IncomingEmail.Port)
|
|
})
|
|
})
|
|
}
|