1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-08-05 01:45:22 +02:00
forgejo/routers/api/v1/repo
oliverpool 7ad20a2730 git/blob: GetContentBase64 with fewer allocations and no goroutine (#8297)
See #8222 for context.i

`GetBlobContentBase64` was using a pipe and a goroutine to read the blob content as base64. This can be replace by a pre-allocated buffer and a direct copy.

Note that although similar to `GetBlobContent`, it does not truncate the content if the blob size is over the limit (but returns an error). I think that `GetBlobContent` should adopt the same behavior at some point (error instead of truncating).

### Tests

- I added test coverage for Go changes...
  - [x] in their respective `*_test.go` for unit tests.
- [x] I did not document these changes and I do not expect someone else to do it.

### Release notes

- [x] I do not want this change to show in the release notes.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/8297
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2025-06-27 11:22:10 +02:00
..
action.go bug: unify RepoActionRun and ActionRun structs (#8250) 2025-06-23 07:54:32 +02:00
avatar.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
blob.go feat: API GET /repos/{owner}/{repo}/git/blobs 2025-06-13 13:52:56 +02:00
branch.go chore(cleanup): replaces unnecessary calls to formatting functions by non-formatting equivalents (#7994) 2025-05-29 17:34:29 +02:00
collaborators.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
commits.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
compare.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
download.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
file.go API: enforce sha requirement on POST /repos/{owner}/{repo}/contents (#8139) 2025-06-12 00:13:39 +02:00
flags.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
fork.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
git_hook.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
git_ref.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
hook.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
hook_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
issue.go feat: show more relevant results for 'dependencies' dropdown (#8003) 2025-06-26 20:06:21 +02:00
issue_attachment.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
issue_comment.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
issue_comment_attachment.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
issue_dependency.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
issue_label.go chore(cleanup): replaces unnecessary calls to formatting functions by non-formatting equivalents (#7994) 2025-05-29 17:34:29 +02:00
issue_pin.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
issue_reaction.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
issue_stopwatch.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
issue_subscription.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
issue_tracked_time.go chore(cleanup): replaces unnecessary calls to formatting functions by non-formatting equivalents (#7994) 2025-05-29 17:34:29 +02:00
key.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
label.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
language.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
main_test.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
migrate.go fix: do not fail when release or wiki is set in /repos/migrate API (#8155) 2025-06-12 11:12:58 +02:00
milestone.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
mirror.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
notes.go chore(cleanup): replaces unnecessary calls to formatting functions by non-formatting equivalents (#7994) 2025-05-29 17:34:29 +02:00
patch.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
pull.go [gitea] week 2025-21 cherry pick (gitea/main -> forgejo) (#8040) 2025-06-16 20:27:47 +02:00
pull_review.go chore(cleanup): replaces unnecessary calls to formatting functions by non-formatting equivalents (#7994) 2025-05-29 17:34:29 +02:00
release.go chore(cleanup): replaces unnecessary calls to formatting functions by non-formatting equivalents (#7994) 2025-05-29 17:34:29 +02:00
release_attachment.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
release_tags.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repo.go fix: do not fail when release or wiki is set in /repos/migrate API (#8155) 2025-06-12 11:12:58 +02:00
repo_test.go Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
star.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
status.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
subscriber.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
sync_fork.go feat: sync forks (#2364) 2025-04-07 07:00:38 +00:00
tag.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
teams.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
topic.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
transfer.go chore(cleanup): replaces unnecessary calls to formatting functions by non-formatting equivalents (#7994) 2025-05-29 17:34:29 +02:00
tree.go chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
wiki.go git/blob: GetContentBase64 with fewer allocations and no goroutine (#8297) 2025-06-27 11:22:10 +02:00