Docker/mealie
Docker/mealie
1
0
Fork 0
mirror of https://github.com/mealie-recipes/mealie.git synced 2025-08-02 20:15:24 +02:00
Code Issues Releases Activity

feat: more shopping list enhancements (#2587)

Browse source 
* fix new position calculataion

* ensure consistent list item ordering

* fix recipe ref overflow on small screens

* added recipe ref elevation

* tweaked line height (for long notes)

* removed unused user dependency

* remove old shopping list items when there's >100

* 🤷

* cleaned up function generator

* fixed test

* fix potential type error

* made max position calc more efficient
This commit is contained in:
Michael Genson 2023-10-07 16:06:00 -05:00 • committed by GitHub
parent f35bc77a7d
commit b153ddf858
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 189 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

15
frontend/pages/shopping-lists/_id.vue
View file

@ -268,6 +268,7 @@ export default defineComponent({
// only update the list with the new value if we're not loading, to prevent UI jitter
if (!loadingCounter.value) {
shoppingList.value = newListValue;
sortListItems();
updateItemsByLabel();
}
}
@ -473,6 +474,15 @@ export default defineComponent({
const itemsByLabel = ref<{ [key: string]: ShoppingListItemOut[] }>({});
function sortListItems() {
if (!shoppingList.value?.listItems?.length) {
return;
}
// sort by position ascending, then createdAt descending
shoppingList.value.listItems.sort((a, b) => (a.position > b.position || a.createdAt < b.createdAt ? 1 : -1))
}
function updateItemsByLabel() {
const items: { [prop: string]: ShoppingListItemOut[] } = {};
const noLabelText = i18n.tc("shopping-list.no-label");
@ -603,6 +613,7 @@ export default defineComponent({
});
}
sortListItems();
updateItemsByLabel();
loadingCounter.value += 1;
@ -656,7 +667,9 @@ export default defineComponent({
loadingCounter.value += 1;
// make sure it's inserted into the end of the list, which may have been updated
createListItemData.value.position = shoppingList.value?.listItems?.length || 1;
createListItemData.value.position = shoppingList.value?.listItems?.length
? (shoppingList.value.listItems.reduce((a, b) => (a.position || 0) > (b.position || 0) ? a : b).position || 0) + 1
: 0;
const { data } = await userApi.shopping.items.createOne(createListItemData.value);
loadingCounter.value -= 1;