Docker/mealie
Docker/mealie
1
0
Fork 0
mirror of https://github.com/mealie-recipes/mealie.git synced 2025-08-05 13:35:23 +02:00
Code Issues Releases Activity

fix: Use reserved example.com as bogus instead of email.com domain. (#2551)

Browse source 
`email.com` is not a reserved domain, incorrect configuration could result in unintentional effects.
`example.com` is reserved by IANA for bogus purposes, see RFC 6761.
This commit is contained in:
Flightkick 2023-09-23 15:56:34 +00:00 • committed by GitHub
parent a22d500603
commit bb9afd86c1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
14 changed files with 22 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/integration_tests/admin_tests/test_admin_user_actions.py
View file

@ -124,7 +124,7 @@ def test_self_promote_admin(api_client: TestClient, unique_user: TestUser):
update_data = {
"id": unique_user.user_id,
"fullName": "Updated Name",
"email": "user@email.com",
"email": "user@example.com",
"group": "Home",
"admin": True,
}

2
tests/integration_tests/test_validators.py
View file

@ -31,7 +31,7 @@ def test_validators_username(api_client: TestClient, unique_user: TestUser):
def test_validators_email(api_client: TestClient, unique_user: TestUser):
emails = [
SimpleCase(value=unique_user.email, is_valid=False),
SimpleCase(value=f"{random_string()}@email.com", is_valid=True),
SimpleCase(value=f"{random_string()}@example.com", is_valid=True),
]
for user in emails:

2
tests/unit_tests/services_tests/test_email_service.py
View file

@ -4,7 +4,7 @@ from mealie.core.config import get_app_settings
from mealie.services.email import EmailService
from mealie.services.email.email_senders import ABCEmailSender
FAKE_ADDRESS = "my_secret_email@email.com"
FAKE_ADDRESS = "my_secret_email@example.com"
SUBJECTS = {"Mealie Forgot Password", "Invitation to join Mealie", "Test Email"}

10
tests/unit_tests/validator_tests/test_registration_validators.py
View file

@ -7,7 +7,7 @@ def test_create_user_registration() -> None:
CreateUserRegistration(
group="Home",
group_token=None,
email="SomeValidEmail@email.com",
email="SomeValidEmail@example.com",
username="SomeValidUsername",
password="SomeValidPassword",
password_confirm="SomeValidPassword",
@ -18,7 +18,7 @@ def test_create_user_registration() -> None:
CreateUserRegistration(
group=None,
group_token="asdfadsfasdfasdfasdf",
email="SomeValidEmail@email.com",
email="SomeValidEmail@example.com",
username="SomeValidUsername",
password="SomeValidPassword",
password_confirm="SomeValidPassword",
@ -33,7 +33,7 @@ def test_group_or_token_validator(group, group_token) -> None:
CreateUserRegistration(
group=group,
group_token=group_token,
email="SomeValidEmail@email.com",
email="SomeValidEmail@example.com",
username="SomeValidUsername",
password="SomeValidPassword",
password_confirm="SomeValidPassword",
@ -45,7 +45,7 @@ def test_group_or_token_validator(group, group_token) -> None:
def test_group_no_args_passed() -> None:
with pytest.raises(ValueError):
CreateUserRegistration(
email="SomeValidEmail@email.com",
email="SomeValidEmail@example.com",
username="SomeValidUsername",
password="SomeValidPassword",
password_confirm="SomeValidPassword",
@ -59,7 +59,7 @@ def test_password_validator() -> None:
CreateUserRegistration(
group=None,
group_token="asdfadsfasdfasdfasdf",
email="SomeValidEmail@email.com",
email="SomeValidEmail@example.com",
username="SomeValidUsername",
password="SomeValidPassword",
password_confirm="PasswordDefNotMatch",