mirror of
https://github.com/mealie-recipes/mealie.git
synced 2025-07-24 07:39:41 +02:00
Refactor/conver to controllers (#923)
* add dependency injection for get_repositories * convert events api to controller * update generic typing * add abstract controllers * update test naming * migrate admin services to controllers * add additional admin route tests * remove print * add public shared dependencies * add types * fix typo * add static variables for recipe json keys * add coverage gutters config * update controller routers * add generic success response * add category/tag/tool tests * add token refresh test * add coverage utilities * covert comments to controller * add todo * add helper properties * delete old service * update test notes * add unit test for pretty_stats * remove dead code from post_webhooks * update group routes to use controllers * add additional group test coverage * abstract common permission checks * convert ingredient parser to controller * update recipe crud to use controller * remove dead-code * add class lifespan tracker for debugging * convert bulk export to controller * migrate tools router to controller * update recipe share to controller * move customer router to _base * ignore prints in flake8 * convert units and foods to new controllers * migrate user routes to controllers * centralize error handling * fix invalid ref * reorder fields * update routers to share common handling * update tests * remove prints * fix cookbooks delete * fix cookbook get * add controller for mealplanner * cover report routes to controller * remove __future__ imports * remove dead code * remove all base_http children and remove dead code
This commit is contained in:
parent
5823a32daf
commit
c4540f1395
164 changed files with 3111 additions and 3213 deletions
|
@ -0,0 +1,79 @@
|
|||
from fastapi.testclient import TestClient
|
||||
|
||||
from tests.utils.assertion_helpers import assert_ignore_keys
|
||||
from tests.utils.factories import random_bool, random_string
|
||||
from tests.utils.fixture_schemas import TestUser
|
||||
|
||||
|
||||
class Routes:
|
||||
base = "/api/admin/groups"
|
||||
|
||||
def item(id: str) -> str:
|
||||
return f"{Routes.base}/{id}"
|
||||
|
||||
def user(id: str) -> str:
|
||||
return f"api/admin/users/{id}"
|
||||
|
||||
|
||||
def test_home_group_not_deletable(api_client: TestClient, admin_user: TestUser):
|
||||
response = api_client.delete(Routes.item(admin_user.group_id), headers=admin_user.token)
|
||||
assert response.status_code == 400
|
||||
|
||||
|
||||
def test_admin_group_routes_are_restricted(api_client: TestClient, unique_user: TestUser, admin_user: TestUser):
|
||||
response = api_client.get(Routes.base, headers=unique_user.token)
|
||||
assert response.status_code == 403
|
||||
|
||||
response = api_client.post(Routes.base, json={}, headers=unique_user.token)
|
||||
assert response.status_code == 403
|
||||
|
||||
response = api_client.get(Routes.item(admin_user.group_id), headers=unique_user.token)
|
||||
assert response.status_code == 403
|
||||
|
||||
response = api_client.get(Routes.user(admin_user.group_id), headers=unique_user.token)
|
||||
assert response.status_code == 403
|
||||
|
||||
|
||||
def test_admin_create_group(api_client: TestClient, admin_user: TestUser):
|
||||
response = api_client.post(Routes.base, json={"name": random_string()}, headers=admin_user.token)
|
||||
assert response.status_code == 201
|
||||
|
||||
|
||||
def test_admin_update_group(api_client: TestClient, admin_user: TestUser, unique_user: TestUser):
|
||||
update_payload = {
|
||||
"id": unique_user.group_id,
|
||||
"name": "New Name",
|
||||
"preferences": {
|
||||
"privateGroup": random_bool(),
|
||||
"firstDayOfWeek": 2,
|
||||
"recipePublic": random_bool(),
|
||||
"recipeShowNutrition": random_bool(),
|
||||
"recipeShowAssets": random_bool(),
|
||||
"recipeLandscapeView": random_bool(),
|
||||
"recipeDisableComments": random_bool(),
|
||||
"recipeDisableAmount": random_bool(),
|
||||
},
|
||||
}
|
||||
|
||||
response = api_client.put(Routes.item(unique_user.group_id), json=update_payload, headers=admin_user.token)
|
||||
|
||||
assert response.status_code == 200
|
||||
|
||||
as_json = response.json()
|
||||
|
||||
assert as_json["name"] == update_payload["name"]
|
||||
assert_ignore_keys(as_json["preferences"], update_payload["preferences"])
|
||||
|
||||
|
||||
def test_admin_delete_group(api_client: TestClient, admin_user: TestUser, unique_user: TestUser):
|
||||
# Delete User
|
||||
response = api_client.delete(Routes.user(unique_user.user_id), headers=admin_user.token)
|
||||
assert response.status_code == 200
|
||||
|
||||
# Delete Group
|
||||
response = api_client.delete(Routes.item(unique_user.group_id), headers=admin_user.token)
|
||||
assert response.status_code == 200
|
||||
|
||||
# Ensure Group is Deleted
|
||||
response = api_client.get(Routes.item(unique_user.group_id), headers=admin_user.token)
|
||||
assert response.status_code == 404
|
Loading…
Add table
Add a link
Reference in a new issue