Docker/mealie
Docker/mealie
1
0
Fork 0
mirror of https://github.com/mealie-recipes/mealie.git synced 2025-08-05 21:45:25 +02:00
Code Issues Releases Activity

Fix OIDC infinite loop if user is not in OIDC_USER_GROUP (#3487)
Some checks are pending
CodeQL / Analyze (javascript-typescript) (push) Waiting to run
Details
CodeQL / Analyze (python) (push) Waiting to run
Details
Docker Nightly Production / Backend Server Tests (push) Waiting to run
Details
Docker Nightly Production / Frontend and End-to-End Tests (push) Waiting to run
Details
Docker Nightly Production / Build Tagged Release (push) Blocked by required conditions
Details
Docker Nightly Production / Notify Discord (push) Blocked by required conditions
Details

Browse source
This commit is contained in:
Carter 2024-04-18 19:17:45 -05:00 • committed by GitHub
parent 84dad84326
commit c6f5b62ad0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 44 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

1
tests/e2e/docker/docker-compose.yml
View file

@ -30,6 +30,7 @@ services:
OIDC_AUTH_ENABLED: True
OIDC_SIGNUP_ENABLED: True
OIDC_USER_GROUP: user
OIDC_ADMIN_GROUP: admin
OIDC_CONFIGURATION_URL: http://localhost:8080/default/.well-known/openid-configuration
OIDC_CLIENT_ID: default

31
tests/e2e/login.spec.ts
View file

@ -55,7 +55,8 @@ test('oidc initial login', async ({ page }) => {
"sub": username,
"email": `${username}@example.com`,
"preferred_username": username,
"name": name
"name": name,
"groups": ["user"]
}
await page.goto('http://localhost:9000/login');
@ -67,6 +68,26 @@ test('oidc initial login', async ({ page }) => {
await expect(page.getByRole('link', { name: 'Settings' })).not.toBeVisible();
});
test('oidc login with user not in propery group', async ({ page }) => {
const username = "testUserNoGroup"
const name = "Test User No Group"
const claims = {
"sub": username,
"email": `${username}@example.com`,
"preferred_username": username,
"name": name,
"groups": []
}
await page.goto('http://localhost:9000/login');
await page.getByRole('button', { name: 'Login with OAuth' }).click();
await page.getByPlaceholder('Enter any user/subject').fill(username);
await page.getByPlaceholder('Optional claims JSON value,').fill(JSON.stringify(claims));
await page.getByRole('button', { name: 'Sign-in' }).click();
await expect(page).toHaveURL(/.*\/login\/?\?direct=1/)
await expect(page.getByRole('button', { name: 'Login with OAuth' })).toBeVisible()
});
test('oidc sequential login', async ({ page }) => {
const username = "testUser2"
const name = "Test User 2"
@ -74,7 +95,8 @@ test('oidc sequential login', async ({ page }) => {
"sub": username,
"email": `${username}@example.com`,
"preferred_username": username,
"name": name
"name": name,
"groups": ["user"]
}
await page.goto('http://localhost:9000/login');
@ -100,7 +122,8 @@ test('settings page verify oidc', async ({ page }) => {
"sub": username,
"email": `${username}@example.com`,
"preferred_username": username,
"name": name
"name": name,
"groups": ["user"]
}
await page.goto('http://localhost:9000/login');
@ -133,7 +156,7 @@ test('oidc admin user', async ({ page }) => {
"email": `${username}@example.com`,
"preferred_username": username,
"name": name,
"groups": ["admin"]
"groups": ["user", "admin"]
}
await page.goto('http://localhost:9000/login');