1
0
Fork 0
mirror of https://github.com/mealie-recipes/mealie.git synced 2025-08-05 13:35:23 +02:00

feat: Use Backend for Recipe Post Actions (#4163)

This commit is contained in:
Michael Genson 2024-09-14 09:59:36 -05:00 committed by GitHub
parent 8bd26d2230
commit d8dbcac196
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 159 additions and 25 deletions

View file

@ -1,26 +1,51 @@
from uuid import UUID, uuid4
import pytest
import requests
from fastapi.testclient import TestClient
from mealie.schema.household.group_recipe_action import (
CreateGroupRecipeAction,
GroupRecipeActionOut,
GroupRecipeActionType,
SaveGroupRecipeAction,
)
from mealie.schema.recipe.recipe import Recipe
from tests.utils import api_routes, assert_deserialize
from tests.utils.factories import random_int, random_string
from tests.utils.fixture_schemas import TestUser
def new_link_action() -> CreateGroupRecipeAction:
@pytest.fixture(autouse=True)
def mock_requests_post(monkeypatch: pytest.MonkeyPatch):
monkeypatch.setattr(requests, "post", lambda *args, **kwargs: None)
def create_action(action_type: GroupRecipeActionType = GroupRecipeActionType.link) -> CreateGroupRecipeAction:
return CreateGroupRecipeAction(
action_type=GroupRecipeActionType.link,
action_type=action_type,
title=random_string(),
url=random_string(),
)
def save_action(
user: TestUser, action_type: GroupRecipeActionType = GroupRecipeActionType.link
) -> SaveGroupRecipeAction:
action = create_action(action_type)
return action.cast(SaveGroupRecipeAction, group_id=UUID(user.group_id), household_id=UUID(user.household_id))
def new_recipe(user: TestUser) -> Recipe:
return Recipe(
user_id=user.user_id,
group_id=UUID(user.group_id),
name=random_string(),
)
def test_group_recipe_actions_create_one(api_client: TestClient, unique_user: TestUser):
action_in = new_link_action()
action_in = create_action()
response = api_client.post(
api_routes.households_recipe_actions,
json=action_in.model_dump(),
@ -42,7 +67,7 @@ def test_group_recipe_actions_get_all(api_client: TestClient, unique_user: TestU
for _ in range(random_int(3, 5)):
response = api_client.post(
api_routes.households_recipe_actions,
json=new_link_action().model_dump(),
json=create_action().model_dump(),
headers=unique_user.token,
)
data = assert_deserialize(response, 201)
@ -59,7 +84,7 @@ def test_group_recipe_actions_get_all(api_client: TestClient, unique_user: TestU
def test_group_recipe_actions_get_one(
api_client: TestClient, unique_user: TestUser, g2_user: TestUser, is_own_group: bool
):
action_in = new_link_action()
action_in = create_action()
response = api_client.post(
api_routes.households_recipe_actions,
json=action_in.model_dump(),
@ -87,7 +112,7 @@ def test_group_recipe_actions_get_one(
def test_group_recipe_actions_update_one(api_client: TestClient, unique_user: TestUser):
action_in = new_link_action()
action_in = create_action()
response = api_client.post(
api_routes.households_recipe_actions,
json=action_in.model_dump(),
@ -110,7 +135,7 @@ def test_group_recipe_actions_update_one(api_client: TestClient, unique_user: Te
def test_group_recipe_actions_delete_one(api_client: TestClient, unique_user: TestUser):
action_in = new_link_action()
action_in = create_action()
response = api_client.post(
api_routes.households_recipe_actions,
json=action_in.model_dump(),
@ -124,3 +149,46 @@ def test_group_recipe_actions_delete_one(api_client: TestClient, unique_user: Te
response = api_client.get(api_routes.households_recipe_actions_item_id(action_id), headers=unique_user.token)
assert response.status_code == 404
@pytest.mark.parametrize("missing_action", [True, False])
@pytest.mark.parametrize("missing_recipe", [True, False])
def test_group_recipe_actions_trigger_post(
api_client: TestClient, unique_user: TestUser, missing_action: bool, missing_recipe: bool
):
if missing_action:
action_id = uuid4()
else:
recipe_action = unique_user.repos.group_recipe_actions.create(
save_action(unique_user, GroupRecipeActionType.post)
)
action_id = recipe_action.id
if missing_recipe:
recipe_slug = random_string()
else:
recipe = unique_user.repos.recipes.create(new_recipe(unique_user))
recipe_slug = recipe.slug
response = api_client.post(
api_routes.households_recipe_actions_item_id_trigger_recipe_slug(action_id, recipe_slug),
headers=unique_user.token,
)
if missing_action or missing_recipe:
assert response.status_code == 404
else:
# we don't test if the request was actually made, just that the endpoint was hit and accepted
assert response.status_code == 202
def test_group_recipe_actions_trigger_invalid_type(api_client: TestClient, unique_user: TestUser):
recipe_action = unique_user.repos.group_recipe_actions.create(save_action(unique_user, GroupRecipeActionType.link))
recipe = unique_user.repos.recipes.create(new_recipe(unique_user))
response = api_client.post(
api_routes.households_recipe_actions_item_id_trigger_recipe_slug(recipe_action.id, recipe.id),
headers=unique_user.token,
)
assert response.status_code == 400

View file

@ -332,6 +332,11 @@ def households_recipe_actions_item_id(item_id):
return f"{prefix}/households/recipe-actions/{item_id}"
def households_recipe_actions_item_id_trigger_recipe_slug(item_id, recipe_slug):
"""`/api/households/recipe-actions/{item_id}/trigger/{recipe_slug}`"""
return f"{prefix}/households/recipe-actions/{item_id}/trigger/{recipe_slug}"
def households_shopping_items_item_id(item_id):
"""`/api/households/shopping/items/{item_id}`"""
return f"{prefix}/households/shopping/items/{item_id}"