Docker/mealie
Docker/mealie
1
0
Fork 0
mirror of https://github.com/mealie-recipes/mealie.git synced 2025-08-02 20:15:24 +02:00
Code Issues Releases Activity

fix: unclosed sessions (#1734)

Browse source 
* resolve session leak

* cleanup session management functions
This commit is contained in:
Hayden 2022-10-17 14:11:40 -08:00 • committed by GitHub
parent a3904c45d8
commit e516a2e801
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
12 changed files with 132 additions and 90 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/integration_tests/user_tests/test_user_password_reset_service.py
View file

@ -3,7 +3,7 @@ import json
import pytest
from fastapi.testclient import TestClient
from mealie.db.db_setup import create_session
from mealie.db.db_setup import session_context
from mealie.services.user_services.password_reset_service import PasswordResetService
from tests.utils.factories import random_string
from tests.utils.fixture_schemas import TestUser
@ -31,10 +31,10 @@ def test_password_reset(api_client: TestClient, unique_user: TestUser, casing: s
cased_email += l.lower()
cased_email
session = create_session()
service = PasswordResetService(session)
token = service.generate_reset_token(cased_email)
assert token is not None
with session_context() as session:
service = PasswordResetService(session)
token = service.generate_reset_token(cased_email)
assert token is not None
new_password = random_string(15)
@ -59,8 +59,6 @@ def test_password_reset(api_client: TestClient, unique_user: TestUser, casing: s
response = api_client.get(Routes.self, headers={"Authorization": f"Bearer {new_token}"})
assert response.status_code == 200
session.close()
# Test successful password reset
response = api_client.post(Routes.base, json=payload)
assert response.status_code == 400