Fix more typing issues (#928)

* Fix or comment several ts-ignores

* Fix typing related to BaseOverflowButton

* Remove unused functionality of useCookbooks, fix usage bug

* Fix more typing, add some comments

* Only allow ts-ignore if it has a comment

frontend/components/Domain/Recipe/RecipeDialogShare.vue

@@ -22,7 +22,7 @@
               v-on="on"
             ></v-text-field>
           </template>
-          <v-date-picker v-model="expirationDate" no-title @input="pickerMenu = false"></v-date-picker>
+          <v-date-picker v-model="expirationDate" no-title @input="datePickerMenu = false"></v-date-picker>
         </v-menu>
       </v-card-text>
       <v-card-actions class="justify-end">
@@ -178,4 +178,4 @@ export default defineComponent({
     };
   },
 });
-</script>
+</script>

frontend/components/Domain/Recipe/RecipeIngredients.vue

@@ -25,7 +25,7 @@
 
 <script lang="ts">
 import { computed, defineComponent, reactive, toRefs } from "@nuxtjs/composition-api";
-// @ts-ignore
+// @ts-ignore vue-markdown has no types
 import VueMarkdown from "@adapttive/vue-markdown";
 import { parseIngredientText } from "~/composables/recipes";
 import { RecipeIngredient } from "~/types/api-types/recipe";

frontend/components/Domain/Recipe/RecipeInstructions.vue

@@ -178,7 +178,7 @@
 
 <script lang="ts">
 import draggable from "vuedraggable";
-// @ts-ignore
+// @ts-ignore vue-markdown has no types
 import VueMarkdown from "@adapttive/vue-markdown";
 import { ref, toRefs, reactive, defineComponent, watch, onMounted } from "@nuxtjs/composition-api";
 import { RecipeStep, IngredientReferences, RecipeIngredient } from "~/types/api-types/recipe";

frontend/components/Domain/Recipe/RecipeNotes.vue

@@ -32,9 +32,10 @@
 </template>
 
 <script lang="ts">
-// @ts-ignore
+// @ts-ignore vue-markdown has no types
 import VueMarkdown from "@adapttive/vue-markdown";
 import { defineComponent } from "@nuxtjs/composition-api";
+import { RecipeNote } from "~/types/api-types/recipe";
 
 export default defineComponent({
   components: {
@@ -42,7 +43,7 @@ export default defineComponent({
   },
   props: {
     value: {
-      type: Array,
+      type: Array as () => RecipeNote[],
       required: true,
     },
 

frontend/components/Domain/Recipe/RecipePrintView.vue

@@ -68,7 +68,7 @@
 
 <script lang="ts">
 import { defineComponent } from "@nuxtjs/composition-api";
-// @ts-ignore
+// @ts-ignore vue-markdown has no types
 import VueMarkdown from "@adapttive/vue-markdown";
 import RecipeTimeCard from "~/components/Domain/Recipe/RecipeTimeCard.vue";
 import { Recipe } from "~/types/api-types/recipe";

frontend/components/Domain/Recipe/RecipeTools.vue

@@ -47,13 +47,13 @@
 
 <script lang="ts">
 import { defineComponent, ref, computed } from "@nuxtjs/composition-api";
-import { Tool } from "~/api/class-interfaces/tools";
+import { RecipeTool } from "~/types/api-types/recipe";
 import { useTools } from "~/composables/recipes";
 
 export default defineComponent({
   props: {
     value: {
-      type: Array as () => Tool[],
+      type: Array as () => RecipeTool[],
       required: true,
     },
     edit: {

frontend/components/global/BaseButtonGroup.vue

@@ -42,7 +42,7 @@ export interface ButtonOption {
   icon: string;
   text: string;
   event: string;
-  children: ButtonOption[];
+  children?: ButtonOption[];
 }
 
 export default defineComponent({

frontend/components/global/BaseDialog.vue

@@ -136,8 +136,6 @@ export default defineComponent({
   watch: {
     determineClose() {
       this.submitted = false;
-
-      // @ts-ignore
       this.dialog = false;
     },
     dialog(val) {
@@ -155,12 +153,10 @@ export default defineComponent({
       this.submitted = true;
     },
     open() {
-      // @ts-ignore
       this.dialog = true;
       this.logDeprecatedProp("open");
     },
     close() {
-      // @ts-ignore
       this.dialog = false;
       this.logDeprecatedProp("close");
     },

frontend/components/global/BaseOverflowButton.vue

@@ -60,9 +60,10 @@ const MODES = {
 
 export interface MenuItem {
   text: string;
-  icon: string;
+  icon?: string;
   to?: string;
-  event: string;
+  value?: string;
+  event?: string;
 }
 
 export default defineComponent({
@@ -78,6 +79,7 @@ export default defineComponent({
     disabled: {
       type: Boolean,
       required: false,
+      default: false,
     },
     value: {
       type: String,
@@ -96,28 +98,24 @@ export default defineComponent({
     },
   },
   setup(props, context) {
-    const activeObj = ref({
+    const activeObj = ref<MenuItem>({
       text: "DEFAULT",
       value: "",
-      icon: undefined,
-      event: undefined,
     });
 
     let startIndex = 0;
     props.items.forEach((item, index) => {
-      // @ts-ignore
       if (item.value === props.value) {
         startIndex = index;
 
-        // @ts-ignore
         activeObj.value = item;
       }
     });
     const itemGroup = ref(startIndex);
 
-    function setValue(v: any) {
+    function setValue(v: MenuItem) {
       context.emit(INPUT_EVENT, v.value);
-      activeObj.value = v;
+      activeObj.value = v; 
     }
 
     return {

frontend/components/global/MarkdownEditor.vue

@@ -26,7 +26,7 @@
 </template>
 
 <script lang="ts">
-// @ts-ignore
+// @ts-ignore vue-markdown has no types
 import VueMarkdown from "@adapttive/vue-markdown";
 
 import { defineComponent, computed, ref } from "@nuxtjs/composition-api";

frontend/components/global/RecipeJsonEditor.vue

@@ -9,7 +9,7 @@
 </template>
 
 <script lang="ts">
-// @ts-ignore
+// @ts-ignore v-jsoneditor has no types
 import VJsoneditor from "v-jsoneditor";
 import { defineComponent } from "@nuxtjs/composition-api";