1
0
Fork 0
mirror of https://github.com/mealie-recipes/mealie.git synced 2025-07-23 07:09:41 +02:00

Fix more typing issues (#928)

* Fix or comment several ts-ignores

* Fix typing related to BaseOverflowButton

* Remove unused functionality of useCookbooks, fix usage bug

* Fix more typing, add some comments

* Only allow ts-ignore if it has a comment
This commit is contained in:
Philipp Fischbeck 2022-01-16 03:38:11 +01:00 committed by GitHub
parent c4540f1395
commit f794208862
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
45 changed files with 126 additions and 249 deletions

View file

@ -71,6 +71,8 @@ import { defineComponent, reactive, ref, toRefs } from "@nuxtjs/composition-api"
import { Confidence, Parser } from "~/api/class-interfaces/recipes/types";
import { useUserApi } from "~/composables/api";
type ConfidenceAttribute = "average" | "comment" | "name" | "unit" | "quantity" | "food";
export default defineComponent({
layout: "admin",
setup() {
@ -85,11 +87,12 @@ export default defineComponent({
const confidence = ref<Confidence>({});
function getColor(attribute: string) {
function getColor(attribute: ConfidenceAttribute) {
const percentage = getConfidence(attribute);
if (percentage === undefined)
return;
// @ts-ignore
const p_as_num = parseFloat(percentage?.replace("%", ""));
const p_as_num = parseFloat(percentage.replace("%", ""));
// Set color based off range
if (p_as_num > 75) {
@ -101,18 +104,16 @@ export default defineComponent({
}
}
function getConfidence(attribute: string) {
attribute = attribute.toLowerCase();
function getConfidence(attribute: ConfidenceAttribute) {
if (!confidence.value) {
return;
}
// @ts-ignore
const property: number = confidence.value[attribute];
if (property) {
const property = confidence.value[attribute];
if (property !== undefined) {
return `${(property * 100).toFixed(0)}%`;
}
return null;
return undefined;
}
const tryText = [
@ -150,18 +151,18 @@ export default defineComponent({
properties.unit.value = data.ingredient?.unit?.name || "";
properties.food.value = data.ingredient?.food?.name || "";
for (const property in properties) {
(["comment", "quantity", "unit", "food"] as ConfidenceAttribute[]).forEach(property => {
const color = getColor(property);
const confidence = getConfidence(property);
if (color) {
// @ts-ignore
// @ts-ignore See above
properties[property].color = color;
}
if (confidence) {
// @ts-ignore
// @ts-ignore See above
properties[property].confidence = confidence;
}
}
});
}
state.loading = false;
}
@ -169,7 +170,7 @@ export default defineComponent({
const properties = reactive({
quantity: {
subtitle: "Quantity",
value: "" as any,
value: "" as string | number,
color: null,
confidence: null,
},