mirror of
https://github.com/mealie-recipes/mealie.git
synced 2025-08-02 12:05:21 +02:00
9ecef4c25f
This PR does too many things :(
1. Major refactoring of the dev/scripts and dev/code-generation folders.
Primarily this was removing duplicate code and cleaning up some poorly written code snippets as well as making them more idempotent so then can be re-run over and over again but still maintain the same results. This is working on my machine, but I've been having problems in CI and comparing diffs so running generators in CI will have to wait.
2. Re-Implement using the generated api routes for testing
This was a _huge_ refactor that touched damn near every test file but now we have auto-generated typed routes with inline hints and it's used for nearly every test excluding a few that use classes for better parameterization. This should greatly reduce errors when writing new tests.
3. Minor Perf improvements for the All Recipes endpoint
A. Removed redundant loops
B. Uses orjson to do the encoding directly and returns a byte response instead of relying on the default
jsonable_encoder.
4. Fix some TS type errors that cropped up for seemingly no reason half way through the PR.
See this issue https://github.com/phillipdupuis/pydantic-to-typescript/issues/28
Basically, the generated TS type is not-correct since Pydantic will automatically fill in null fields. The resulting TS type is generated with a ? to indicate it can be null even though we _know_ that i can't be.
105 lines
3.9 KiB
Python
105 lines
3.9 KiB
Python
from fastapi.testclient import TestClient
|
|
|
|
from tests.utils import api_routes
|
|
from tests.utils.factories import random_string
|
|
from tests.utils.fixture_schemas import TestUser
|
|
|
|
|
|
def test_ownership_on_new_with_admin(api_client: TestClient, admin_user: TestUser):
|
|
recipe_name = random_string()
|
|
response = api_client.post(api_routes.recipes, json={"name": recipe_name}, headers=admin_user.token)
|
|
assert response.status_code == 201
|
|
|
|
recipe = api_client.get(api_routes.recipes + f"/{recipe_name}", headers=admin_user.token).json()
|
|
|
|
assert recipe["userId"] == admin_user.user_id
|
|
assert recipe["groupId"] == admin_user.group_id
|
|
|
|
|
|
def test_ownership_on_new_with_user(api_client: TestClient, g2_user: TestUser):
|
|
recipe_name = random_string()
|
|
response = api_client.post(api_routes.recipes, json={"name": recipe_name}, headers=g2_user.token)
|
|
assert response.status_code == 201
|
|
|
|
response = api_client.get(api_routes.recipes + f"/{recipe_name}", headers=g2_user.token)
|
|
|
|
assert response.status_code == 200
|
|
|
|
recipe = response.json()
|
|
|
|
assert recipe["userId"] == g2_user.user_id
|
|
assert recipe["groupId"] == g2_user.group_id
|
|
|
|
|
|
def test_get_all_only_includes_group_recipes(api_client: TestClient, unique_user: TestUser):
|
|
for _ in range(5):
|
|
recipe_name = random_string()
|
|
response = api_client.post(api_routes.recipes, json={"name": recipe_name}, headers=unique_user.token)
|
|
|
|
response = api_client.get(api_routes.recipes, headers=unique_user.token)
|
|
|
|
assert response.status_code == 200
|
|
|
|
recipes = response.json()["items"]
|
|
|
|
assert len(recipes) == 5
|
|
|
|
for recipe in recipes:
|
|
assert recipe["groupId"] == unique_user.group_id
|
|
assert recipe["userId"] == unique_user.user_id
|
|
|
|
|
|
def test_unique_slug_by_group(api_client: TestClient, unique_user: TestUser, g2_user: TestUser) -> None:
|
|
create_data = {"name": random_string()}
|
|
|
|
response = api_client.post(api_routes.recipes, json=create_data, headers=unique_user.token)
|
|
assert response.status_code == 201
|
|
|
|
response = api_client.post(api_routes.recipes, json=create_data, headers=g2_user.token)
|
|
assert response.status_code == 201
|
|
|
|
# Try to create a recipe again with the same name and check that the name was incremented
|
|
response = api_client.post(api_routes.recipes, json=create_data, headers=g2_user.token)
|
|
assert response.status_code == 201
|
|
assert response.json() == create_data["name"] + "-1"
|
|
|
|
|
|
def test_user_locked_recipe(api_client: TestClient, user_tuple: list[TestUser]) -> None:
|
|
usr_1, usr_2 = user_tuple
|
|
|
|
# Setup Recipe
|
|
recipe_name = random_string()
|
|
response = api_client.post(api_routes.recipes, json={"name": recipe_name}, headers=usr_1.token)
|
|
assert response.status_code == 201
|
|
|
|
# Get Recipe
|
|
response = api_client.get(api_routes.recipes + f"/{recipe_name}", headers=usr_1.token)
|
|
assert response.status_code == 200
|
|
recipe = response.json()
|
|
|
|
# Lock Recipe
|
|
recipe["settings"]["locked"] = True
|
|
response = api_client.put(api_routes.recipes + f"/{recipe_name}", json=recipe, headers=usr_1.token)
|
|
|
|
# Try To Update Recipe with User 2
|
|
response = api_client.put(api_routes.recipes + f"/{recipe_name}", json=recipe, headers=usr_2.token)
|
|
assert response.status_code == 403
|
|
|
|
|
|
def test_other_user_cant_lock_recipe(api_client: TestClient, user_tuple: list[TestUser]) -> None:
|
|
usr_1, usr_2 = user_tuple
|
|
|
|
# Setup Recipe
|
|
recipe_name = random_string()
|
|
response = api_client.post(api_routes.recipes, json={"name": recipe_name}, headers=usr_1.token)
|
|
assert response.status_code == 201
|
|
|
|
# Get Recipe
|
|
response = api_client.get(api_routes.recipes + f"/{recipe_name}", headers=usr_2.token)
|
|
assert response.status_code == 200
|
|
recipe = response.json()
|
|
|
|
# Lock Recipe
|
|
recipe["settings"]["locked"] = True
|
|
response = api_client.put(api_routes.recipes + f"/{recipe_name}", json=recipe, headers=usr_2.token)
|
|
assert response.status_code == 403
|