feat: Version 2

Closes #627, closes #1047

server/api/controllers/project-managers/create.js

@@ -1,4 +1,14 @@
+/*!
+ * Copyright (c) 2024 PLANKA Software GmbH
+ * Licensed under the Fair Use License: https://github.com/plankanban/planka/blob/master/LICENSE.md
+ */
+
+const { idInput } = require('../../../utils/inputs');
+
 const Errors = {
+  NOT_ENOUGH_RIGHTS: {
+    notEnoughRights: 'Not enough rights',
+  },
   PROJECT_NOT_FOUND: {
     projectNotFound: 'Project not found',
   },
@@ -8,23 +18,27 @@ const Errors = {
   USER_ALREADY_PROJECT_MANAGER: {
     userAlreadyProjectManager: 'User already project manager',
   },
+  USER_MUST_BE_ADMIN_OR_PROJECT_OWNER: {
+    userMustBeAdminOrProjectOwner: 'User must be admin or project owner',
+  },
 };
 
 module.exports = {
   inputs: {
     projectId: {
-      type: 'string',
-      regex: /^[0-9]+$/,
+      ...idInput,
       required: true,
     },
     userId: {
-      type: 'string',
-      regex: /^[0-9]+$/,
+      ...idInput,
       required: true,
     },
   },
 
   exits: {
+    notEnoughRights: {
+      responseType: 'forbidden',
+    },
     projectNotFound: {
       responseType: 'notFound',
     },
@@ -34,27 +48,41 @@ module.exports = {
     userAlreadyProjectManager: {
       responseType: 'conflict',
     },
+    userMustBeAdminOrProjectOwner: {
+      responseType: 'unprocessableEntity',
+    },
   },
 
   async fn(inputs) {
     const { currentUser } = this.req;
 
-    const project = await Project.findOne(inputs.projectId);
+    const project = await Project.qm.getOneById(inputs.projectId);
 
     if (!project) {
       throw Errors.PROJECT_NOT_FOUND;
     }
 
-    const isProjectManager = await sails.helpers.users.isProjectManager(currentUser.id, project.id);
+    if (currentUser.role !== User.Roles.ADMIN) {
+      const isProjectManager = await sails.helpers.users.isProjectManager(
+        currentUser.id,
+        project.id,
+      );
 
-    if (!isProjectManager) {
-      throw Errors.PROJECT_NOT_FOUND; // Forbidden
+      if (!isProjectManager) {
+        throw Errors.PROJECT_NOT_FOUND; // Forbidden
+      }
     }
 
-    const user = await sails.helpers.users.getOne(inputs.userId);
+    if (project.ownerProjectManagerId) {
+      throw Errors.NOT_ENOUGH_RIGHTS;
+    }
+
+    const user = await User.qm.getOneById(inputs.userId, {
+      withDeactivated: false,
+    });
 
     if (!user) {
-      throw Error.USER_NOT_FOUND;
+      throw Errors.USER_NOT_FOUND;
     }
 
     const projectManager = await sails.helpers.projectManagers.createOne
@@ -66,7 +94,11 @@ module.exports = {
         actorUser: currentUser,
         request: this.req,
       })
-      .intercept('userAlreadyProjectManager', () => Errors.USER_ALREADY_PROJECT_MANAGER);
+      .intercept('userAlreadyProjectManager', () => Errors.USER_ALREADY_PROJECT_MANAGER)
+      .intercept(
+        'userInValuesMustBeAdminOrProjectOwner',
+        () => Errors.USER_MUST_BE_ADMIN_OR_PROJECT_OWNER,
+      );
 
     return {
       item: projectManager,

server/api/controllers/project-managers/delete.js

@@ -1,48 +1,78 @@
+/*!
+ * Copyright (c) 2024 PLANKA Software GmbH
+ * Licensed under the Fair Use License: https://github.com/plankanban/planka/blob/master/LICENSE.md
+ */
+
+const { idInput } = require('../../../utils/inputs');
+
 const Errors = {
+  NOT_ENOUGH_RIGHTS: {
+    notEnoughRights: 'Not enough rights',
+  },
   PROJECT_MANAGER_NOT_FOUND: {
     projectManagerNotFound: 'Project manager not found',
   },
+  MUST_NOT_BE_LAST: {
+    mustNotBeLast: 'Must not be last',
+  },
 };
 
 module.exports = {
   inputs: {
     id: {
-      type: 'string',
-      regex: /^[0-9]+$/,
+      ...idInput,
       required: true,
     },
   },
 
   exits: {
+    notEnoughRights: {
+      responseType: 'forbidden',
+    },
     projectManagerNotFound: {
       responseType: 'notFound',
     },
+    mustNotBeLast: {
+      responseType: 'unprocessableEntity',
+    },
   },
 
   async fn(inputs) {
     const { currentUser } = this.req;
 
-    let projectManager = await ProjectManager.findOne(inputs.id);
+    const pathToProject = await sails.helpers.projectManagers
+      .getPathToProjectById(inputs.id)
+      .intercept('pathNotFound', () => Errors.PROJECT_MANAGER_NOT_FOUND);
 
-    if (!projectManager) {
-      throw Errors.PROJECT_MANAGER_NOT_FOUND;
+    let { projectManager } = pathToProject;
+    const { project } = pathToProject;
+
+    if (currentUser.role !== User.Roles.ADMIN) {
+      const isProjectManager = await sails.helpers.users.isProjectManager(
+        currentUser.id,
+        project.id,
+      );
+
+      if (!isProjectManager) {
+        throw Errors.PROJECT_MANAGER_NOT_FOUND; // Forbidden
+      }
     }
 
-    const isProjectManager = await sails.helpers.users.isProjectManager(
-      currentUser.id,
-      projectManager.projectId,
-    );
-
-    if (!isProjectManager) {
-      throw Errors.PROJECT_MANAGER_NOT_FOUND; // Forbidden
+    if (project.ownerProjectManagerId) {
+      throw Errors.NOT_ENOUGH_RIGHTS;
     }
 
-    // TODO: check if the last one
-    projectManager = await sails.helpers.projectManagers.deleteOne.with({
-      record: projectManager,
-      actorUser: currentUser,
-      request: this.req,
-    });
+    const user = await User.qm.getOneById(projectManager.userId);
+
+    projectManager = await sails.helpers.projectManagers.deleteOne
+      .with({
+        user,
+        project,
+        record: projectManager,
+        actorUser: currentUser,
+        request: this.req,
+      })
+      .intercept('mustNotBeLast', () => Errors.MUST_NOT_BE_LAST);
 
     if (!projectManager) {
       throw Errors.PROJECT_MANAGER_NOT_FOUND;