Docker/planka
Docker/planka
1
0
Fork 0
mirror of https://github.com/plankanban/planka.git synced 2025-07-18 20:59:44 +02:00
Code Issues Releases Activity

fix: Subscribe only when needed

Browse source
This commit is contained in:
Maksim Eltyshev 2023-01-05 15:03:06 +01:00
parent b955e933b2
commit 58eda7d555
10 changed files with 28 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

4
server/api/controllers/boards/create.js
View file

@ -108,10 +108,6 @@ module.exports = {
request: this.req,
});
if (this.req.isSocket) {
sails.sockets.join(this.req, `board:${board.id}`); // TODO: only when subscription needed
}
return {
item: board,
included: {

7
server/api/controllers/boards/show.js
View file

@ -11,6 +11,9 @@ module.exports = {
regex: /^[0-9]+$/,
required: true,
},
subscribe: {
type: 'boolean',
},
},
exits: {
@ -73,8 +76,8 @@ module.exports = {
card.isSubscribed = isSubscribedByCardId[card.id] || false;
});
if (this.req.isSocket) {
sails.sockets.join(this.req, `board:${board.id}`); // TODO: only when subscription needed
if (inputs.subscribe && this.req.isSocket) {
sails.sockets.join(this.req, `board:${board.id}`);
}
return {

7
server/api/controllers/users/show.js
View file

@ -13,6 +13,9 @@ module.exports = {
regex: /^[0-9]+|me$/,
required: true,
},
subscribe: {
type: 'boolean',
},
},
exits: {
@ -26,8 +29,8 @@ module.exports = {
if (inputs.id === CURRENT_USER_ID) {
({ currentUser: user } = this.req);
if (this.req.isSocket) {
sails.sockets.join(this.req, `user:${user.id}`); // TODO: only when subscription needed
if (inputs.subscribe && this.req.isSocket) {
sails.sockets.join(this.req, `user:${user.id}`);
}
} else {
user = await sails.helpers.users.getOne(inputs.id);