1
0
Fork 0
mirror of https://github.com/plankanban/planka.git synced 2025-07-19 05:09:43 +02:00

ref: Remove board types, refactoring

This commit is contained in:
Maksim Eltyshev 2022-12-26 21:10:50 +01:00
parent d39da61295
commit 5cd025ffb7
182 changed files with 1573 additions and 1239 deletions

View file

@ -1,15 +1,24 @@
const valuesValidator = (value) => {
if (!_.isPlainObject(value)) {
return false;
}
if (!_.isPlainObject(value.board)) {
return false;
}
if (!_.isPlainObject(value.user)) {
return false;
}
return true;
};
module.exports = {
inputs: {
values: {
type: 'json',
required: true,
},
user: {
type: 'ref',
required: true,
},
board: {
type: 'ref',
custom: valuesValidator,
required: true,
},
request: {
@ -22,18 +31,20 @@ module.exports = {
},
async fn(inputs) {
if (inputs.values.role === BoardMembership.Roles.EDITOR) {
delete inputs.values.canComment; // eslint-disable-line no-param-reassign
} else if (inputs.values.role === BoardMembership.Roles.VIEWER) {
if (_.isNil(inputs.values.canComment)) {
inputs.values.canComment = false; // eslint-disable-line no-param-reassign
const { values } = inputs;
if (values.role === BoardMembership.Roles.EDITOR) {
delete values.canComment;
} else if (values.role === BoardMembership.Roles.VIEWER) {
if (_.isNil(values.canComment)) {
values.canComment = false;
}
}
const boardMembership = await BoardMembership.create({
...inputs.values,
boardId: inputs.board.id,
userId: inputs.user.id,
...values,
boardId: values.board.id,
userId: values.user.id,
})
.intercept('E_UNIQUE', 'userAlreadyBoardMember')
.fetch();

View file

@ -1,8 +1,10 @@
const criteriaValidator = (value) => _.isArray(value) || _.isPlainObject(value);
module.exports = {
inputs: {
criteria: {
type: 'json',
custom: (value) => _.isArray(value) || _.isPlainObject(value),
custom: criteriaValidator,
},
},

View file

@ -14,21 +14,22 @@ module.exports = {
},
async fn(inputs) {
const role = inputs.values.role || inputs.record.role;
const { values } = inputs;
const role = values.role || inputs.record.role;
if (role === BoardMembership.Roles.EDITOR) {
inputs.values.canComment = null; // eslint-disable-line no-param-reassign
values.canComment = null;
} else if (role === BoardMembership.Roles.VIEWER) {
const canComment = _.isUndefined(inputs.values.canComment)
const canComment = _.isUndefined(values.canComment)
? inputs.record.canComment
: inputs.values.canComment;
: values.canComment;
if (_.isNull(canComment)) {
inputs.values.canComment = false; // eslint-disable-line no-param-reassign
values.canComment = false;
}
}
const boardMembership = await BoardMembership.updateOne(inputs.record.id).set(inputs.values);
const boardMembership = await BoardMembership.updateOne(inputs.record.id).set({ ...values });
if (boardMembership) {
sails.sockets.broadcast(