Docker/planka
Docker/planka
1
0
Fork 0
mirror of https://github.com/plankanban/planka.git synced 2025-07-20 13:49:43 +02:00
Code Issues Releases Activity

fix: more generic error messages on login

Browse source
This commit is contained in:
Aurélien TRONCY 2024-08-28 22:25:44 +02:00
parent b2e1fba9a0
commit 9a5049472f
6 changed files with 28 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
server/api/controllers/access-tokens/create.js
View file

@ -10,6 +10,9 @@ const Errors = {
INVALID_PASSWORD: {
invalidPassword: 'Invalid password',
},
INVALID_CREDENTIALS: {
invalidCredentials: 'Invalid credentials',
},
USE_SINGLE_SIGN_ON: {
useSingleSignOn: 'Use single sign-on',
},
@ -40,6 +43,9 @@ module.exports = {
invalidPassword: {
responseType: 'unauthorized',
},
invalidCredentials: {
responseType: 'unauthorized',
},
useSingleSignOn: {
responseType: 'forbidden',
},
@ -57,6 +63,9 @@ module.exports = {
sails.log.warn(
`Invalid email or username: "${inputs.emailOrUsername}"! (IP: ${remoteAddress})`,
);
if (sails.config.custom.enableVerboseOnLogin) {
throw Errors.INVALID_CREDENTIALS;
}
throw Errors.INVALID_EMAIL_OR_USERNAME;
}
@ -66,6 +75,9 @@ module.exports = {
if (!bcrypt.compareSync(inputs.password, user.password)) {
sails.log.warn(`Invalid password! (IP: ${remoteAddress})`);
if (sails.config.custom.enableVerboseOnLogin) {
throw Errors.INVALID_CREDENTIALS;
}
throw Errors.INVALID_PASSWORD;
}