Docker/planka
Docker/planka
1
0
Fork 0
mirror of https://github.com/plankanban/planka.git synced 2025-08-10 07:55:27 +02:00
Code Issues Releases Activity

refactor: extract code from controllers to helpers

Browse source
This commit is contained in:
Matthieu Bollot 2024-04-05 14:45:13 +02:00
parent 4e02efa0ee
commit b1ad354815
No known key found for this signature in database
GPG key ID: 426E24F35CBB5BC2
8 changed files with 35 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

7
server/api/controllers/cards/create.js
View file

@ -1,5 +1,4 @@
const moment = require('moment');
const services = require('../../services/slack');
const Errors = {
NOT_ENOUGH_RIGHTS: {
@ -110,12 +109,6 @@ module.exports = {
})
.intercept('positionMustBeInValues', () => Errors.POSITION_MUST_BE_PRESENT);
const cardUrl = services.buildCardUrl(card);
const messageText = `${cardUrl} was created by ${currentUser.name} in *${list.name}*`;
services.sendSlackMessage(messageText).catch((error) => {
throw new Error('Failed to send Slack message:', error.message);
});
return {
item: card,
};

7
server/api/controllers/cards/delete.js
View file

@ -1,5 +1,3 @@
const services = require('../../services/slack');
const Errors = {
NOT_ENOUGH_RIGHTS: {
notEnoughRights: 'Not enough rights',
@ -56,11 +54,6 @@ module.exports = {
throw Errors.CARD_NOT_FOUND;
}
const messageText = `*${card.name}* was deleted by ${currentUser.name}`;
services.sendSlackMessage(messageText).catch((error) => {
throw new Error('Failed to send Slack message:', error.message);
});
return {
item: card,
};

14
server/api/controllers/cards/update.js
View file

@ -1,5 +1,4 @@
const moment = require('moment');
const services = require('../../services/slack');
const Errors = {
NOT_ENOUGH_RIGHTS: {
@ -176,8 +175,6 @@ module.exports = {
'isSubscribed',
]);
const cardPositionBefore = card.position;
card = await sails.helpers.cards.updateOne
.with({
board,
@ -198,17 +195,6 @@ module.exports = {
throw Errors.CARD_NOT_FOUND;
}
const cardPositionAfter = card.position;
const cardMoved = cardPositionBefore !== cardPositionAfter;
if (cardMoved) {
const cardUrl = services.buildCardUrl(card);
const messageText = `${cardUrl} was moved by ${currentUser.name} to *${nextList.name}*`;
services.sendSlackMessage(messageText).catch((error) => {
throw new Error('Failed to send Slack message:', error.message);
});
}
return {
item: card,
};

8
server/api/controllers/comment-actions/create.js
View file

@ -1,5 +1,3 @@
const services = require('../../services/slack');
const Errors = {
NOT_ENOUGH_RIGHTS: {
notEnoughRights: 'Not enough rights',
@ -66,12 +64,6 @@ module.exports = {
request: this.req,
});
const cardUrl = services.buildCardUrl(card);
const messageText = `*${currentUser.name}* commented on ${cardUrl}:\n>${inputs.text}`;
services.sendSlackMessage(messageText).catch((error) => {
throw new Error('Failed to send Slack message:', error.message);
});
return {
item: action,
};

8
server/api/helpers/actions/create-one.js
View file

@ -1,3 +1,5 @@
const services = require('../../services/slack');
const valuesValidator = (value) => {
if (!_.isPlainObject(value)) {
return false;
@ -67,6 +69,12 @@ module.exports = {
),
);
const cardUrl = services.buildCardUrl(values.card);
const messageText = `*${inputs.values.user.name}* commented on ${cardUrl}:\n>${values.data.text}`;
services.sendSlackMessage(messageText).catch((error) => {
sails.log.error('Failed to send Slack message:', error.message);
});
return action;
},
};

8
server/api/helpers/cards/create-one.js
View file

@ -1,3 +1,5 @@
const services = require('../../services/slack');
const valuesValidator = (value) => {
if (!_.isPlainObject(value)) {
return false;
@ -111,6 +113,12 @@ module.exports = {
board: inputs.board,
});
const cardUrl = services.buildCardUrl(card);
const messageText = `${cardUrl} was created by ${values.creatorUser.name} in *${values.list.name}*`;
services.sendSlackMessage(messageText).catch((error) => {
sails.log.error('Failed to send Slack message:', error.message);
});
return card;
},
};

7
server/api/helpers/cards/delete-one.js
View file

@ -1,3 +1,5 @@
const services = require('../../services/slack');
module.exports = {
inputs: {
record: {
@ -21,6 +23,11 @@ module.exports = {
},
inputs.request,
);
const messageText = `*${card.name}* was deleted by ${inputs.request.name}`;
services.sendSlackMessage(messageText).catch((error) => {
sails.log.error('Failed to send Slack message:', error.message);
});
}
return card;

12
server/api/helpers/cards/update-one.js
View file

@ -1,3 +1,5 @@
const services = require('../../services/slack');
const valuesValidator = (value) => {
if (!_.isPlainObject(value)) {
return false;
@ -269,6 +271,16 @@ module.exports = {
}
}
const cardMoved = inputs.values.list !== undefined;
if (cardMoved) {
const cardUrl = services.buildCardUrl(card);
const messageText = `${cardUrl} was moved by ${inputs.user.name} to *${inputs.list.name}*`;
services.sendSlackMessage(messageText).catch((error) => {
sails.log.error('Failed to send Slack message:', error.message);
});
}
return card;
},
};