1
0
Fork 0
mirror of https://github.com/plankanban/planka.git synced 2025-07-25 08:09:44 +02:00

Project managers, board members, auto-update after reconnection, refactoring

This commit is contained in:
Maksim Eltyshev 2021-06-24 01:05:22 +05:00
parent d6cb1f6683
commit b39119ace4
478 changed files with 21226 additions and 19495 deletions

View file

@ -81,20 +81,17 @@ module.exports = {
},
},
async fn(inputs, exits) {
async fn(inputs) {
const { currentUser } = this.req;
const { board, project } = await sails.helpers
.getBoardToProjectPath(inputs.boardId)
const { board } = await sails.helpers.boards
.getProjectPath(inputs.boardId)
.intercept('pathNotFound', () => Errors.BOARD_NOT_FOUND);
const isUserMemberForProject = await sails.helpers.isUserMemberForProject(
project.id,
currentUser.id,
);
const isBoardMember = await sails.helpers.users.isBoardMember(currentUser.id, board.id);
if (!isUserMemberForProject) {
throw Errors.LIST_NOT_FOUND; // Forbidden
if (!isBoardMember) {
throw Errors.BOARD_NOT_FOUND; // Forbidden
}
let list;
@ -111,19 +108,13 @@ module.exports = {
const values = _.pick(inputs, ['position', 'name', 'description', 'dueDate', 'timer']);
const card = await sails.helpers
.createCard(board, list, values, currentUser, this.req)
const card = await sails.helpers.cards
.createOne(values, currentUser, board, list, this.req)
.intercept('listMustBePresent', () => Errors.LIST_MUST_BE_PRESENT)
.intercept('positionMustBeInValues', () => Errors.POSITION_MUST_BE_PRESENT);
return exits.success({
return {
item: card,
included: {
cardMemberships: [],
cardLabels: [],
tasks: [],
attachments: [],
},
});
};
},
};

View file

@ -19,33 +19,27 @@ module.exports = {
},
},
async fn(inputs, exits) {
async fn(inputs) {
const { currentUser } = this.req;
const cardToProjectPath = await sails.helpers
.getCardToProjectPath(inputs.id)
let { card } = await sails.helpers.cards
.getProjectPath(inputs.id)
.intercept('pathNotFound', () => Errors.CARD_NOT_FOUND);
let { card } = cardToProjectPath;
const { project } = cardToProjectPath;
const isBoardMember = await sails.helpers.users.isBoardMember(currentUser.id, card.boardId);
const isUserMemberForProject = await sails.helpers.isUserMemberForProject(
project.id,
currentUser.id,
);
if (!isUserMemberForProject) {
if (!isBoardMember) {
throw Errors.CARD_NOT_FOUND; // Forbidden
}
card = await sails.helpers.deleteCard(card, this.req);
card = await sails.helpers.cards.deleteOne(card, this.req);
if (!card) {
throw Errors.CARD_NOT_FOUND;
}
return exits.success({
return {
item: card,
});
};
},
};

View file

@ -26,32 +26,23 @@ module.exports = {
async fn(inputs, exits) {
const { currentUser } = this.req;
const { board, project } = await sails.helpers
.getBoardToProjectPath(inputs.boardId)
const { board } = await sails.helpers.boards
.getProjectPath(inputs.boardId)
.intercept('pathNotFound', () => Errors.BOARD_NOT_FOUND);
const isUserMemberForProject = await sails.helpers.isUserMemberForProject(
project.id,
currentUser.id,
);
const isBoardMember = await sails.helpers.users.isBoardMember(currentUser.id, board.id);
if (!isUserMemberForProject) {
if (!isBoardMember) {
throw Errors.BOARD_NOT_FOUND; // Forbidden
}
const cards = await sails.helpers.getCardsForBoard(board, inputs.beforeId);
const cardIds = sails.helpers.mapRecords(cards);
const cards = await sails.helpers.boards.getCards(board, inputs.beforeId);
const cardIds = sails.helpers.utils.mapRecords(cards);
const cardSubscriptions = await sails.helpers.getSubscriptionsByUserForCard(
cardIds,
currentUser.id,
);
const cardMemberships = await sails.helpers.getMembershipsForCard(cardIds);
const cardLabels = await sails.helpers.getCardLabelsForCard(cardIds);
const tasks = await sails.helpers.getTasksForCard(cardIds);
const attachments = await sails.helpers.getAttachmentsForCard(cardIds);
const cardSubscriptions = await sails.helpers.cardSubscriptions.getMany({
cardId: cardIds,
userId: currentUser.id,
});
const isSubscribedByCardId = cardSubscriptions.reduce(
(result, cardSubscription) => ({
@ -61,10 +52,14 @@ module.exports = {
{},
);
cards.map((card) => ({
...card,
isSubscribed: isSubscribedByCardId[card.id] || false,
}));
cards.forEach((card) => {
card.isSubscribed = isSubscribedByCardId[card.id] || false; // eslint-disable-line no-param-reassign
});
const cardMemberships = await sails.helpers.cards.getCardMemberships(cardIds);
const cardLabels = await sails.helpers.cards.getCardLabels(cardIds);
const tasks = await sails.helpers.cards.getTasks(cardIds);
const attachments = await sails.helpers.cards.getAttachments(cardIds);
return exits.success({
items: cards,

View file

@ -19,24 +19,41 @@ module.exports = {
},
},
async fn(inputs, exits) {
async fn(inputs) {
const { currentUser } = this.req;
const { card, project } = await sails.helpers
.getCardToProjectPath(inputs.id)
const { card, project } = await sails.helpers.cards
.getProjectPath(inputs.id)
.intercept('pathNotFound', () => Errors.CARD_NOT_FOUND);
const isUserMemberForProject = await sails.helpers.isUserMemberForProject(
project.id,
currentUser.id,
);
const isBoardMember = await sails.helpers.users.isBoardMember(currentUser.id, card.boardId);
if (!isUserMemberForProject) {
throw Errors.CARD_NOT_FOUND; // Forbidden
if (!isBoardMember) {
const isProjectManager = await sails.helpers.users.isProjectManager(
currentUser.id,
project.id,
);
if (!isProjectManager) {
throw Errors.CARD_NOT_FOUND; // Forbidden
}
}
return exits.success({
card.isSubscribed = await sails.helpers.users.isCardSubscriber(currentUser.id, card.id);
const cardMemberships = await sails.helpers.cards.getCardMemberships(card.id);
const cardLabels = await sails.helpers.cards.getCardLabels(card.id);
const tasks = await sails.helpers.cards.getTasks(card.id);
const attachments = await sails.helpers.cards.getAttachments(card.id);
return {
item: card,
});
included: {
cardMemberships,
cardLabels,
tasks,
attachments,
},
};
},
};

View file

@ -100,49 +100,43 @@ module.exports = {
},
},
async fn(inputs, exits) {
async fn(inputs) {
const { currentUser } = this.req;
const cardToProjectPath = await sails.helpers
.getCardToProjectPath(inputs.id)
const path = await sails.helpers.cards
.getProjectPath(inputs.id)
.intercept('pathNotFound', () => Errors.CARD_NOT_FOUND);
let { card, project } = cardToProjectPath;
const { list, board } = cardToProjectPath;
let { card } = path;
const { list, board } = path;
let isUserMemberForProject = await sails.helpers.isUserMemberForProject(
project.id,
currentUser.id,
);
let isBoardMember = await sails.helpers.users.isBoardMember(currentUser.id, board.id);
if (!isUserMemberForProject) {
if (!isBoardMember) {
throw Errors.CARD_NOT_FOUND; // Forbidden
}
let toBoard;
let nextBoard;
if (!_.isUndefined(inputs.boardId)) {
({ board: toBoard, project } = await sails.helpers
.getBoardToProjectPath(inputs.boardId)
({ board: nextBoard } = await sails.helpers.boards
.getProjectPath(inputs.boardId)
.intercept('pathNotFound', () => Errors.BOARD_NOT_FOUND));
isUserMemberForProject = await sails.helpers.isUserMemberForProject(
project.id,
currentUser.id,
);
isBoardMember = await sails.helpers.users.isBoardMember(currentUser.id, nextBoard.id);
if (!isUserMemberForProject) {
if (!isBoardMember) {
throw Errors.BOARD_NOT_FOUND; // Forbidden
}
}
let toList;
let nextList;
if (!_.isUndefined(inputs.listId)) {
toList = await List.findOne({
nextList = await List.findOne({
id: inputs.listId,
boardId: (toBoard || board).id,
boardId: (nextBoard || board).id,
});
if (!toList) {
if (!nextList) {
throw Errors.LIST_NOT_FOUND; // Forbidden
}
}
@ -157,17 +151,17 @@ module.exports = {
'isSubscribed',
]);
card = await sails.helpers
.updateCard(card, toBoard, toList, values, board, list, currentUser, this.req)
.intercept('toListMustBePresent', () => Errors.LIST_MUST_BE_PRESENT)
card = await sails.helpers.cards
.updateOne(card, values, nextBoard, nextList, currentUser, board, list, this.req)
.intercept('nextListMustBePresent', () => Errors.LIST_MUST_BE_PRESENT)
.intercept('positionMustBeInValues', () => Errors.POSITION_MUST_BE_PRESENT);
if (!card) {
throw Errors.CARD_NOT_FOUND;
}
return exits.success({
return {
item: card,
});
};
},
};