Fix attachment duplication on add

client/src/api/attachments.js

@@ -10,8 +10,8 @@ export const transformAttachment = (attachment) => ({
 
 /* Actions */
 
-const createAttachment = (cardId, data, headers) =>
+const createAttachment = (cardId, data, requestId, headers) =>
-  http.post(`/cards/${cardId}/attachments`, data, headers).then((body) => ({
+  http.post(`/cards/${cardId}/attachments?requestId=${requestId}`, data, headers).then((body) => ({
     ...body,
     item: transformAttachment(body.item),
   }));

client/src/sagas/app/requests/attachment.js

@@ -23,7 +23,7 @@ export function* createAttachmentRequest(cardId, localId, data) {
   );
 
   try {
-    const { item } = yield call(request, api.createAttachment, cardId, data);
+    const { item } = yield call(request, api.createAttachment, cardId, data, localId);
 
     const action = createAttachmentSucceeded(localId, item);
     yield put(action);

client/src/sagas/app/services/socket.js

@@ -5,6 +5,7 @@ import { logoutService } from './login';
 import { closeModalService } from './modal';
 import { deleteNotificationsRequest, fetchUsersRequest } from '../requests';
 import {
+  attachmentWithIdExistsSelector,
   currentModalSelector,
   currentUserIdSelector,
   currentUserSelector,
@@ -208,9 +209,13 @@ export function* deleteTaskReceivedService(task) {
   yield put(deleteTaskReceived(task));
 }
 
-export function* createAttachmentReceivedService(attachment) {
+export function* createAttachmentReceivedService(attachment, requestId) {
+  const exists = yield select(attachmentWithIdExistsSelector, requestId);
+
+  if (!exists) {
     yield put(createAttachmentReceived(attachment));
   }
+}
 
 export function* updateAttachmentReceivedService(attachment) {
   yield put(updateAttachmentReceived(attachment));

client/src/sagas/app/watchers/socket.js

@@ -156,8 +156,8 @@ const createSocketEventsChannel = () =>
       emit([deleteTaskReceivedService, item]);
     };
 
-    const handleAttachmentCreate = api.makeHandleAttachmentCreate(({ item }) => {
+    const handleAttachmentCreate = api.makeHandleAttachmentCreate(({ item, requestId }) => {
-      emit([createAttachmentReceivedService, item]);
+      emit([createAttachmentReceivedService, item, requestId]);
     });
 
     const handleAttachmentUpdate = api.makeHandleAttachmentUpdate(({ item }) => {

client/src/selectors/boolean.js

@@ -0,0 +1,11 @@
+import { createSelector } from 'redux-orm';
+
+import orm from '../orm';
+
+// eslint-disable-next-line import/prefer-default-export
+export const attachmentWithIdExistsSelector = () =>
+  createSelector(
+    orm,
+    (_, id) => id,
+    ({ Attachment }, id) => Attachment.idExists(id),
+  );

client/src/selectors/index.js

@@ -3,4 +3,5 @@ export * from './all';
 export * from './path';
 export * from './current';
 export * from './by-id';
+export * from './boolean';
 export * from './next-position';

server/api/controllers/attachments/create.js

@@ -11,6 +11,10 @@ module.exports = {
       regex: /^[0-9]+$/,
       required: true,
     },
+    requestId: {
+      type: 'string',
+      isNotEmptyString: true,
+    },
   },
 
   exits: {
@@ -58,6 +62,7 @@ module.exports = {
           isImage: file.extra.isImage,
           name: file.filename,
         },
+        inputs.requestId,
         this.req,
       );
 

server/api/helpers/create-attachment.js

@@ -12,6 +12,12 @@ module.exports = {
       type: 'json',
       required: true,
     },
+    requestId: {
+      type: 'string',
+      isNotEmptyString: true,
+      allowNull: true,
+      defaultsTo: null,
+    },
     request: {
       type: 'ref',
     },
@@ -29,6 +35,7 @@ module.exports = {
       'attachmentCreate',
       {
         item: attachment,
+        requestId: inputs.requestId,
       },
       inputs.request,
     );