1
0
Fork 0
mirror of https://github.com/plankanban/planka.git synced 2025-07-19 05:09:43 +02:00
Commit graph

57 commits

Author SHA1 Message Date
Maksim Eltyshev
d951ba59dd fix: Disable role change when OIDC roles are not ignored 2023-10-25 23:39:34 +02:00
Balthasar Hofer
e41a434fc8 feat: Add ability to ignore roles when logging in with SSO (#534)
Closes #533
2023-10-26 02:01:35 +05:00
Maksim Eltyshev
0fab6075bd ref: Refactoring 2023-10-19 16:05:34 +02:00
Lorenz Brun
9011ee61da feat: Improve OIDC SSO (#524)
The OIDC implementation merged in https://github.com/plankanban/planka/pull/491 is flawed for multiple reasons.

It assumes that the access_token returned by the IDP has to be a JWT parseable by the RP which is not the case [1].
Many major IDPs do issue tokens which are not JWTs and RPs should not rely on the contents of these at all.
The only signed token which has a standardized format for direct RP consumption is the OIDC ID token (id_token), but this by default doesn't contain many claims, especially role claims are omitted from them by default for size reasons. To get these additional claims into the ID token, one needs an IDP with support for the "claims" parameter.

It requires manual specification of the JWKS URL which is mandatory in any OIDC discovery document and thus never needs to be manually specified.

It also makes the questionable decision to use a client-side code flow with PKCE where a normal code flow would be much more appropriate as all user data is processed in the backend which can securely hold a client secret (confidential client). This has far wider IDP support, is safer (due to direct involvement of the IDP in obtaining user information) and doesn't require working with ID tokens and claim parameters.

By using a server-side code flow we can also offload most complexity to the server alone, no longer requiring an additional OIDC library on the web client.

Also silent logout doesn't work on most IDPs for security reasons, one needs to actually redirect the user over to the IDP, which then prompts them once more if they actually want to log out.

This implementation should work with any OIDC-compliant IDP and even OAuth 2.0-only IDPs as long as they serve and OIDC discovery document.

[1] rfc-editor.org/rfc/rfc6749#section-5.1
2023-10-19 17:39:21 +05:00
Maksim Eltyshev
b9716c6e3a fix: OIDC finalization and refactoring 2023-10-17 19:18:19 +02:00
Maksim Eltyshev
8578883fac fix: Fix saving milliseconds for timestamps 2023-06-12 23:54:57 +02:00
Maksim Eltyshev
a8b7b4dd26 fix: Fix import from Trello
Closes #397
2023-02-20 11:24:17 +01:00
Maksim Eltyshev
6fd42e3b62 fix: Preserve orientation of images
Closes #384
2023-01-17 22:14:39 +01:00
Maksim Eltyshev
a741e26ccb feat: Labels reordering
Closes #289
2023-01-09 12:17:06 +01:00
Maksim Eltyshev
6f79fc45eb ref: Little refactoring 2023-01-08 22:10:41 +01:00
Maksim Eltyshev
0ad9cffb08 fix: Improve quality of resized images 2022-12-26 22:43:21 +01:00
Maksim Eltyshev
5cd025ffb7 ref: Remove board types, refactoring 2022-12-26 21:10:50 +01:00
Maksim Eltyshev
9db355f331 fix: Fix image size for animated attachments 2022-12-24 02:59:03 +01:00
Maksim Eltyshev
05b57142f9 feat: Preserve original format of images, change interpolation kernel
Closes #349
2022-12-24 00:47:59 +01:00
Christoph Enne
948485c861 feat: Trello board JSON import (#352)
Closes #27, closes #105
2022-12-17 03:48:06 +05:00
Maksim Eltyshev
3b5bf6ef5b fix: Fix card repositioning
Closes #340
2022-11-21 17:07:51 +01:00
Maksim Eltyshev
e623e8a3a8 fix: Socket bug fixes and improvements 2022-10-03 12:11:19 +02:00
Maksim Eltyshev
48ea62c0a0 feat: Invalidate access token on logout 2022-09-07 18:39:33 +05:00
Maksim Eltyshev
e4258eda9b fix: Use move-file instead of rename 2022-08-26 16:02:47 +02:00
Maksim Eltyshev
542c4a845c fix: Change mechanics of file uploading 2022-08-26 02:45:27 +02:00
Maksim Eltyshev
f9e0147f33 feat: Permissions for board members
Closes #262
2022-08-19 14:00:40 +02:00
SimonTagne
2b4c2b0f49 feat: Improve security of access tokens (#279)
Closes #275
2022-08-09 21:03:21 +05:00
Maksim Eltyshev
3f8216dca8 ref: Refactoring 2022-08-04 13:31:14 +02:00
Maksim Eltyshev
45f35e8042 feat: Toggle actions details, little redesign 2022-07-29 17:40:18 +02:00
Maksim Eltyshev
f8f2d7345e feat: Add tasks reordering
Closes #50, closes #232
2022-07-21 11:31:05 +02:00
Maksim Eltyshev
39fec45a7f ref: Collapse image data into one column 2022-06-21 12:01:41 +02:00
Maksim Eltyshev
e7541789cd fix: Change way to fix application crash when deleting project 2022-04-28 14:15:36 +05:00
Maksim Eltyshev
ad04208c8a fix: Fix application crash after deleting project 2022-04-28 00:17:15 +05:00
Maksim Eltyshev
2130c04548 Fix board deletion, update dependencies. Closes #146 2021-08-02 17:23:56 +05:00
Maksim Eltyshev
fe91b5241e Project managers, board members, auto-update after reconnection, refactoring 2021-06-24 01:05:22 +05:00
Maksim Eltyshev
ad60517603 Set best image quality for all uploads. Closes #114 2021-04-13 18:47:56 +05:00
Maksim Eltyshev
5f2c24b428 Fix variables in update-card, update dependencies. Closes #85 2021-02-10 17:39:41 +05:00
Maksim Eltyshev
cbadbeb239 Fix loading deleted users on actions fetch. Closes #62 2020-12-13 23:17:12 +05:00
Maksim Eltyshev
30ed77af59 Prepare for collection board type, refactoring, update dependencies 2020-08-04 01:32:46 +05:00
Maksim Eltyshev
c43b4ea8ad Fix removing background 2020-06-04 17:52:30 +05:00
Maksim Eltyshev
f85d499bbf Add validation to background field 2020-06-03 22:27:20 +05:00
Maksim Eltyshev
5bfff3865f Background gradients, migrate from CSS to SCSS, remove !important 2020-05-29 19:31:19 +05:00
Maksim Eltyshev
3bb68b0d4f Add project backgrounds 2020-05-26 00:46:04 +05:00
Maksim Eltyshev
3a1929efba Make columns itself scrollable, fix action creation when moving card, little refactoring 2020-05-16 04:09:46 +05:00
Maksim Eltyshev
66c570f234 Fix members and labels creation when transfer card to another board 2020-05-10 02:06:14 +05:00
Maksim Eltyshev
044fe17dbf Preserve members and labels when transfer card to another board 2020-05-09 05:30:52 +05:00
Maksim Eltyshev
328aa63f6e Remove members and labels when transfer card to another board 2020-05-05 03:33:29 +05:00
Maksim Eltyshev
b1d187476d Move cards between boards and projects 2020-05-05 01:30:06 +05:00
Maksim Eltyshev
d264382fda Add dropzone for attachment, paste attachment from clipboard 2020-04-28 19:46:55 +05:00
Maksim Eltyshev
e0dee1efef Add start script for Docker image, pre-commit lint check, package.json scripts cleanup 2020-04-24 21:44:54 +05:00
Maksim Eltyshev
cb2f795ef1 Fix attachment duplication on add 2020-04-23 05:56:02 +05:00
Maksim Eltyshev
49dc28b0d7 Add covers for cards 2020-04-23 03:02:53 +05:00
Maksim Eltyshev
6a68ec9c1e Add file attachments 2020-04-21 05:44:12 +05:00
Maksim Eltyshev
6a82448dc7 Add preferences tab to user settings, add subscribe to own cards option 2020-04-10 00:11:34 +05:00
Maksim Eltyshev
ce1e1f741d Add username to user 2020-04-03 00:35:25 +05:00