1
0
Fork 0
mirror of https://github.com/plankanban/planka.git synced 2025-07-24 15:49:46 +02:00
Commit graph

81 commits

Author SHA1 Message Date
Maksim Eltyshev
40c04c35ff ref: Refactoring 2023-10-19 16:05:34 +02:00
Lorenz Brun
743f2956c8
feat: Improve OIDC SSO (#524)
The OIDC implementation merged in https://github.com/plankanban/planka/pull/491 is flawed for multiple reasons.

It assumes that the access_token returned by the IDP has to be a JWT parseable by the RP which is not the case [1].
Many major IDPs do issue tokens which are not JWTs and RPs should not rely on the contents of these at all.
The only signed token which has a standardized format for direct RP consumption is the OIDC ID token (id_token), but this by default doesn't contain many claims, especially role claims are omitted from them by default for size reasons. To get these additional claims into the ID token, one needs an IDP with support for the "claims" parameter.

It requires manual specification of the JWKS URL which is mandatory in any OIDC discovery document and thus never needs to be manually specified.

It also makes the questionable decision to use a client-side code flow with PKCE where a normal code flow would be much more appropriate as all user data is processed in the backend which can securely hold a client secret (confidential client). This has far wider IDP support, is safer (due to direct involvement of the IDP in obtaining user information) and doesn't require working with ID tokens and claim parameters.

By using a server-side code flow we can also offload most complexity to the server alone, no longer requiring an additional OIDC library on the web client.

Also silent logout doesn't work on most IDPs for security reasons, one needs to actually redirect the user over to the IDP, which then prompts them once more if they actually want to log out.

This implementation should work with any OIDC-compliant IDP and even OAuth 2.0-only IDPs as long as they serve and OIDC discovery document.

[1] rfc-editor.org/rfc/rfc6749#section-5.1
2023-10-19 17:39:21 +05:00
Maksim Eltyshev
6662b0a717 fix: Fix order of checks when logging in 2023-10-18 23:07:57 +02:00
Maksim Eltyshev
8e0c60f5be fix: OIDC finalization and refactoring 2023-10-17 19:18:19 +02:00
Maksim Eltyshev
91bc889fed feat: Use environment variables for default admin configuration 2023-09-12 01:12:38 +02:00
gorrilla10101
107cb85ba2
feat: OIDC with PKCE flow (#491) 2023-09-04 20:06:59 +05:00
Maksim Eltyshev
d386c82973 fix: Fix saving milliseconds for timestamps 2023-06-12 23:54:57 +02:00
Maksim Eltyshev
d0a2734161 fix: Rename timer to stopwatch
Closes #392
2023-02-27 19:09:51 +01:00
Maksim Eltyshev
8012f5319c fix: Fix import from Trello
Closes #397
2023-02-20 11:24:17 +01:00
Maksim Eltyshev
0f50dbde92 fix: Preserve orientation of images
Closes #384
2023-01-17 22:14:39 +01:00
Maksim Eltyshev
aa69bb8d1e feat: Labels reordering
Closes #289
2023-01-09 12:17:06 +01:00
Maksim Eltyshev
b58b91baa1 ref: Little refactoring 2023-01-08 22:10:41 +01:00
Maksim Eltyshev
6021d67a00 fix: Subscribe only when needed 2023-01-05 15:03:06 +01:00
Maksim Eltyshev
7e07a75124 fix: Improve quality of resized images 2022-12-26 22:43:21 +01:00
Maksim Eltyshev
6ffa817b53 ref: Remove board types, refactoring 2022-12-26 21:10:50 +01:00
Maksim Eltyshev
2bc82d557a fix: Fix image size for animated attachments 2022-12-24 02:59:03 +01:00
Maksim Eltyshev
0a5210dd21 feat: Preserve original format of images, change interpolation kernel
Closes #349
2022-12-24 00:47:59 +01:00
Christoph Enne
738ed19e7f
feat: Trello board JSON import (#352)
Closes #27, closes #105
2022-12-17 03:48:06 +05:00
Maksim Eltyshev
c181731870 fix: Fix card repositioning
Closes #340
2022-11-21 17:07:51 +01:00
Maksim Eltyshev
172f4fcf34 fix: Fix missing board memberships loading 2022-10-03 13:04:52 +02:00
Maksim Eltyshev
9f16881965 fix: Socket bug fixes and improvements 2022-10-03 12:11:19 +02:00
Maksim Eltyshev
8109936ce2 feat: Invalidate access token on logout 2022-09-07 18:39:33 +05:00
Maksim Eltyshev
3df07c10fa fix: Use password strength estimator
Closes #294
2022-09-03 22:47:06 +05:00
Maksim Eltyshev
5c91bddfe7 feat: Stronger password policy 2022-08-26 18:59:44 +02:00
Maksim Eltyshev
5b64d465e2 fix: Use move-file instead of rename 2022-08-26 16:02:47 +02:00
Maksim Eltyshev
cece2254d7 fix: Change mechanics of file uploading 2022-08-26 02:45:27 +02:00
Steven Correia
6429e22d59
feat: Modify logger to log to file that supports fail2ban (#284) 2022-08-23 03:42:56 +05:00
Maksim Eltyshev
51fa7df69c feat: Permissions for board members
Closes #262
2022-08-19 14:00:40 +02:00
Maksim Eltyshev
eea94e0ee2 ref: Little change for consistency 2022-08-09 22:31:43 +02:00
SimonTagne
7786533a90
feat: Improve security of access tokens (#279)
Closes #275
2022-08-09 21:03:21 +05:00
Maksim Eltyshev
3714bbc06f ref: Refactoring 2022-08-04 13:31:14 +02:00
Maksim Eltyshev
ac1df5201d fix: Fix path traversal vulnerability 2022-08-04 00:37:30 +02:00
Maksim Eltyshev
34db8947b6 feat: Toggle actions details, little redesign 2022-07-29 17:40:18 +02:00
Maksim Eltyshev
a148a3aae5 feat: Add language selector
Closes #212
2022-07-26 12:26:42 +02:00
Maksim Eltyshev
ad67b9ba24 feat: Add tasks reordering
Closes #50, closes #232
2022-07-21 11:31:05 +02:00
Maksim Eltyshev
3b3bff1b6b fix: Allow to use endpoints via http 2022-06-24 11:59:04 +02:00
Maksim Eltyshev
6268ced4cb ref: Collapse image data into one column 2022-06-21 12:01:41 +02:00
Maksim Eltyshev
86e4864d1b feat: Add gallery for attachments 2022-06-20 18:27:39 +02:00
Maksim Eltyshev
b0b6587eee fix: Fix attachment headers
Closes #231
2022-04-29 17:21:39 +05:00
Maksim Eltyshev
445b0fc682 fix: Change way to fix application crash when deleting project 2022-04-28 14:15:36 +05:00
Maksim Eltyshev
2e045217ec fix: Fix application crash after deleting project 2022-04-28 00:17:15 +05:00
Maksim Eltyshev
36e4bef21b feat: Remove attachments from public access
Closes #219
2022-04-26 22:20:20 +05:00
Maksim Eltyshev
486e663a3d feat: Store accessToken in cookies instead of localStorage 2022-04-26 18:01:55 +05:00
SimonTagne
31d314736a
Fix updates of username and email 2021-10-21 01:25:04 +05:00
Maksim Eltyshev
1a5c0f53f8 Fix board deletion, update dependencies. Closes #146 2021-08-02 17:23:56 +05:00
Maksim Eltyshev
b39119ace4 Project managers, board members, auto-update after reconnection, refactoring 2021-06-24 01:05:22 +05:00
Maksim Eltyshev
0fb60eb886 Allow dots in username. Closes #116 2021-04-13 18:59:02 +05:00
Maksim Eltyshev
fb42ed460e Set best image quality for all uploads. Closes #114 2021-04-13 18:47:56 +05:00
Maksim Eltyshev
f718464940 Fix variables in update-card, update dependencies. Closes #85 2021-02-10 17:39:41 +05:00
Maksim Eltyshev
3cdb614b57 Fix loading deleted users on actions fetch. Closes #62 2020-12-13 23:17:12 +05:00