1
0
Fork 0
mirror of https://github.com/plankanban/planka.git synced 2025-07-18 20:59:44 +02:00
Commit graph

42 commits

Author SHA1 Message Date
Maksim Eltyshev
6c826c7127 feat: Add ability to enforce SSO
Closes #543, closes #545
2024-04-08 01:24:10 +02:00
Maksim Eltyshev
def2327165 feat: Add ability to map OIDC attributes and ignore username
Closes #554
2024-04-08 01:18:26 +02:00
Maksim Eltyshev
d951ba59dd fix: Disable role change when OIDC roles are not ignored 2023-10-25 23:39:34 +02:00
Balthasar Hofer
e41a434fc8 feat: Add ability to ignore roles when logging in with SSO (#534)
Closes #533
2023-10-26 02:01:35 +05:00
Maksim Eltyshev
0fab6075bd ref: Refactoring 2023-10-19 16:05:34 +02:00
Lorenz Brun
9011ee61da feat: Improve OIDC SSO (#524)
The OIDC implementation merged in https://github.com/plankanban/planka/pull/491 is flawed for multiple reasons.

It assumes that the access_token returned by the IDP has to be a JWT parseable by the RP which is not the case [1].
Many major IDPs do issue tokens which are not JWTs and RPs should not rely on the contents of these at all.
The only signed token which has a standardized format for direct RP consumption is the OIDC ID token (id_token), but this by default doesn't contain many claims, especially role claims are omitted from them by default for size reasons. To get these additional claims into the ID token, one needs an IDP with support for the "claims" parameter.

It requires manual specification of the JWKS URL which is mandatory in any OIDC discovery document and thus never needs to be manually specified.

It also makes the questionable decision to use a client-side code flow with PKCE where a normal code flow would be much more appropriate as all user data is processed in the backend which can securely hold a client secret (confidential client). This has far wider IDP support, is safer (due to direct involvement of the IDP in obtaining user information) and doesn't require working with ID tokens and claim parameters.

By using a server-side code flow we can also offload most complexity to the server alone, no longer requiring an additional OIDC library on the web client.

Also silent logout doesn't work on most IDPs for security reasons, one needs to actually redirect the user over to the IDP, which then prompts them once more if they actually want to log out.

This implementation should work with any OIDC-compliant IDP and even OAuth 2.0-only IDPs as long as they serve and OIDC discovery document.

[1] rfc-editor.org/rfc/rfc6749#section-5.1
2023-10-19 17:39:21 +05:00
Maksim Eltyshev
b9716c6e3a fix: OIDC finalization and refactoring 2023-10-17 19:18:19 +02:00
Maksim Eltyshev
6aefccf543 fix: Fix starting without OIDC environment variables
Closes #503
2023-09-12 01:20:21 +02:00
Maksim Eltyshev
e59535b9b4 feat: Use environment variables for default admin configuration 2023-09-12 01:12:38 +02:00
gorrilla10101
6941500c7b feat: OIDC with PKCE flow (#491) 2023-09-04 20:06:59 +05:00
Maksim Eltyshev
8578883fac fix: Fix saving milliseconds for timestamps 2023-06-12 23:54:57 +02:00
Maksim Eltyshev
5cd025ffb7 ref: Remove board types, refactoring 2022-12-26 21:10:50 +01:00
Maksim Eltyshev
05b57142f9 feat: Preserve original format of images, change interpolation kernel
Closes #349
2022-12-24 00:47:59 +01:00
Jacques Lorentz
2a64fc1a53 fix: Front-end base url with path (#303)
Closes #43, closes #111, closes #272
2022-09-30 14:48:58 +05:00
Maksim Eltyshev
48ea62c0a0 feat: Invalidate access token on logout 2022-09-07 18:39:33 +05:00
Steven Correia
7e79328a70 fix: Fix proxy forwarding (#295) 2022-09-03 20:00:23 +05:00
Maksim Eltyshev
c40709a509 fix: Use custom logger only for production 2022-08-23 20:45:42 +02:00
Steven Correia
fe5fe5fab7 feat: Modify logger to log to file that supports fail2ban (#284) 2022-08-23 03:42:56 +05:00
Maksim Eltyshev
f9e0147f33 feat: Permissions for board members
Closes #262
2022-08-19 14:00:40 +02:00
Maksim Eltyshev
0619a4e579 fix: Provide default value for token expiration 2022-08-09 19:09:07 +02:00
SimonTagne
2b4c2b0f49 feat: Improve security of access tokens (#279)
Closes #275
2022-08-09 21:03:21 +05:00
Maksim Eltyshev
8f4a250705 fix: Fix path traversal vulnerability 2022-08-04 00:37:30 +02:00
Maksim Eltyshev
fe9fdc0191 fix: Fix routes again 2022-06-20 18:48:13 +02:00
Maksim Eltyshev
353d7667f1 fix: Fix routes 2022-06-20 18:46:03 +02:00
Maksim Eltyshev
8f4d60c46f feat: Add gallery for attachments 2022-06-20 18:27:39 +02:00
Maksim Eltyshev
7d138b858d feat: Remove attachments from public access
Closes #219
2022-04-26 22:20:20 +05:00
Maksim Eltyshev
7ef55ec578 feat: Store accessToken in cookies instead of localStorage 2022-04-26 18:01:55 +05:00
dbrennand
778c64ca45 Make trustProxy configurable via environment variable 2021-10-21 01:24:19 +05:00
Maksim Eltyshev
fe91b5241e Project managers, board members, auto-update after reconnection, refactoring 2021-06-24 01:05:22 +05:00
Maksim Eltyshev
fac5254ae8 Change database adapter to support the new Node. Closes #32 2020-08-31 16:45:22 +05:00
Maksim Eltyshev
16acd1b49c Add test libs, update dependencies 2020-08-20 15:35:46 +05:00
Maksim Eltyshev
30ed77af59 Prepare for collection board type, refactoring, update dependencies 2020-08-04 01:32:46 +05:00
Maksim Eltyshev
3bb68b0d4f Add project backgrounds 2020-05-26 00:46:04 +05:00
Maksim Eltyshev
6a68ec9c1e Add file attachments 2020-04-21 05:44:12 +05:00
Maksim Eltyshev
ce1e1f741d Add username to user 2020-04-03 00:35:25 +05:00
Maksim Eltyshev
45bde7e7c0 Move from prettier-eslint to eslint-plugin-prettier, update dependencies 2020-02-03 18:42:31 +05:00
Maksim Eltyshev
7a3805e64c Code formatting with prettier, change eslint config for the server 2019-11-05 18:01:42 +05:00
Maksim Eltyshev
680d664279 Add email and password change functionality for a current user, remove deep compare hooks 2019-10-18 08:06:34 +05:00
Maksim Eltyshev
3848cc194a Change id generation algorithm, display notifications total on the main page 2019-10-10 14:51:59 +05:00
Maksim Eltyshev
b64f5b7b4a Add secret key to environment variables, update readme 2019-10-04 04:19:46 +05:00
Maksim Eltyshev
adbcb67f03 Docker, update readme, update dependencies 2019-10-01 04:18:33 +05:00
Maksim Eltyshev
36fe34e8e1 Initial commit 2019-08-31 04:07:25 +05:00