1
0
Fork 0
mirror of https://github.com/plankanban/planka.git synced 2025-07-18 20:59:44 +02:00
Commit graph

11 commits

Author SHA1 Message Date
Balthasar Hofer
e41a434fc8 feat: Add ability to ignore roles when logging in with SSO (#534)
Closes #533
2023-10-26 02:01:35 +05:00
Maksim Eltyshev
6a09e9a984 fix: Make default admin environment variables optional
Closes #526
2023-10-20 21:52:12 +02:00
Lorenz Brun
9011ee61da feat: Improve OIDC SSO (#524)
The OIDC implementation merged in https://github.com/plankanban/planka/pull/491 is flawed for multiple reasons.

It assumes that the access_token returned by the IDP has to be a JWT parseable by the RP which is not the case [1].
Many major IDPs do issue tokens which are not JWTs and RPs should not rely on the contents of these at all.
The only signed token which has a standardized format for direct RP consumption is the OIDC ID token (id_token), but this by default doesn't contain many claims, especially role claims are omitted from them by default for size reasons. To get these additional claims into the ID token, one needs an IDP with support for the "claims" parameter.

It requires manual specification of the JWKS URL which is mandatory in any OIDC discovery document and thus never needs to be manually specified.

It also makes the questionable decision to use a client-side code flow with PKCE where a normal code flow would be much more appropriate as all user data is processed in the backend which can securely hold a client secret (confidential client). This has far wider IDP support, is safer (due to direct involvement of the IDP in obtaining user information) and doesn't require working with ID tokens and claim parameters.

By using a server-side code flow we can also offload most complexity to the server alone, no longer requiring an additional OIDC library on the web client.

Also silent logout doesn't work on most IDPs for security reasons, one needs to actually redirect the user over to the IDP, which then prompts them once more if they actually want to log out.

This implementation should work with any OIDC-compliant IDP and even OAuth 2.0-only IDPs as long as they serve and OIDC discovery document.

[1] rfc-editor.org/rfc/rfc6749#section-5.1
2023-10-19 17:39:21 +05:00
Maksim Eltyshev
b9716c6e3a fix: OIDC finalization and refactoring 2023-10-17 19:18:19 +02:00
Maksim Eltyshev
e59535b9b4 feat: Use environment variables for default admin configuration 2023-09-12 01:12:38 +02:00
orbatschow
18e231fcaa feat: Allow postgres connections that require ssl mode (#409)
Closes #261
2023-03-06 17:54:52 +05:00
Maksim Eltyshev
e93cc88f5c revert: Allow postgres connections that require ssl mode (#408)
This reverts commit d627a5660a.
2023-02-28 02:56:16 +05:00
orbatschow
d627a5660a feat: Allow postgres connections that require ssl mode (#404)
Closes #261
2023-02-27 21:16:51 +05:00
Maksim Eltyshev
ce1c5a3c69 ref: Prettify env sample 2022-08-09 19:17:19 +02:00
SimonTagne
2b4c2b0f49 feat: Improve security of access tokens (#279)
Closes #275
2022-08-09 21:03:21 +05:00
Maksim Eltyshev
6de4bac8c1 ref: Rename .env file to sample, stop tracking .env file 2022-04-22 16:21:09 +05:00
Renamed from server/.env (Browse further)