1
0
Fork 0
mirror of https://github.com/plankanban/planka.git synced 2025-07-19 05:09:43 +02:00
Commit graph

17 commits

Author SHA1 Message Date
Maksim Eltyshev
856e2efc3c feat: Add ability to map OIDC attributes and ignore username
Closes #554
2024-01-25 23:01:59 +01:00
Maksim Eltyshev
8018b74038 fix: Add issuer to OIDC callback parameters
Closes #562
2023-12-09 16:28:24 +01:00
Maksim Eltyshev
d951ba59dd fix: Disable role change when OIDC roles are not ignored 2023-10-25 23:39:34 +02:00
Balthasar Hofer
e41a434fc8 feat: Add ability to ignore roles when logging in with SSO (#534)
Closes #533
2023-10-26 02:01:35 +05:00
Maksim Eltyshev
0fab6075bd ref: Refactoring 2023-10-19 16:05:34 +02:00
Lorenz Brun
9011ee61da feat: Improve OIDC SSO (#524)
The OIDC implementation merged in https://github.com/plankanban/planka/pull/491 is flawed for multiple reasons.

It assumes that the access_token returned by the IDP has to be a JWT parseable by the RP which is not the case [1].
Many major IDPs do issue tokens which are not JWTs and RPs should not rely on the contents of these at all.
The only signed token which has a standardized format for direct RP consumption is the OIDC ID token (id_token), but this by default doesn't contain many claims, especially role claims are omitted from them by default for size reasons. To get these additional claims into the ID token, one needs an IDP with support for the "claims" parameter.

It requires manual specification of the JWKS URL which is mandatory in any OIDC discovery document and thus never needs to be manually specified.

It also makes the questionable decision to use a client-side code flow with PKCE where a normal code flow would be much more appropriate as all user data is processed in the backend which can securely hold a client secret (confidential client). This has far wider IDP support, is safer (due to direct involvement of the IDP in obtaining user information) and doesn't require working with ID tokens and claim parameters.

By using a server-side code flow we can also offload most complexity to the server alone, no longer requiring an additional OIDC library on the web client.

Also silent logout doesn't work on most IDPs for security reasons, one needs to actually redirect the user over to the IDP, which then prompts them once more if they actually want to log out.

This implementation should work with any OIDC-compliant IDP and even OAuth 2.0-only IDPs as long as they serve and OIDC discovery document.

[1] rfc-editor.org/rfc/rfc6749#section-5.1
2023-10-19 17:39:21 +05:00
Maksim Eltyshev
b9716c6e3a fix: OIDC finalization and refactoring 2023-10-17 19:18:19 +02:00
Maksim Eltyshev
8578883fac fix: Fix saving milliseconds for timestamps 2023-06-12 23:54:57 +02:00
Maksim Eltyshev
6fd42e3b62 fix: Preserve orientation of images
Closes #384
2023-01-17 22:14:39 +01:00
Maksim Eltyshev
6f79fc45eb ref: Little refactoring 2023-01-08 22:10:41 +01:00
Maksim Eltyshev
0ad9cffb08 fix: Improve quality of resized images 2022-12-26 22:43:21 +01:00
Maksim Eltyshev
5cd025ffb7 ref: Remove board types, refactoring 2022-12-26 21:10:50 +01:00
Maksim Eltyshev
05b57142f9 feat: Preserve original format of images, change interpolation kernel
Closes #349
2022-12-24 00:47:59 +01:00
Maksim Eltyshev
e623e8a3a8 fix: Socket bug fixes and improvements 2022-10-03 12:11:19 +02:00
Maksim Eltyshev
542c4a845c fix: Change mechanics of file uploading 2022-08-26 02:45:27 +02:00
SimonTagne
2b4c2b0f49 feat: Improve security of access tokens (#279)
Closes #275
2022-08-09 21:03:21 +05:00
Maksim Eltyshev
fe91b5241e Project managers, board members, auto-update after reconnection, refactoring 2021-06-24 01:05:22 +05:00