1
0
Fork 0
mirror of https://github.com/plankanban/planka.git synced 2025-07-18 20:59:44 +02:00
Commit graph

73 commits

Author SHA1 Message Date
Lorenz Brun
9011ee61da feat: Improve OIDC SSO (#524)
The OIDC implementation merged in https://github.com/plankanban/planka/pull/491 is flawed for multiple reasons.

It assumes that the access_token returned by the IDP has to be a JWT parseable by the RP which is not the case [1].
Many major IDPs do issue tokens which are not JWTs and RPs should not rely on the contents of these at all.
The only signed token which has a standardized format for direct RP consumption is the OIDC ID token (id_token), but this by default doesn't contain many claims, especially role claims are omitted from them by default for size reasons. To get these additional claims into the ID token, one needs an IDP with support for the "claims" parameter.

It requires manual specification of the JWKS URL which is mandatory in any OIDC discovery document and thus never needs to be manually specified.

It also makes the questionable decision to use a client-side code flow with PKCE where a normal code flow would be much more appropriate as all user data is processed in the backend which can securely hold a client secret (confidential client). This has far wider IDP support, is safer (due to direct involvement of the IDP in obtaining user information) and doesn't require working with ID tokens and claim parameters.

By using a server-side code flow we can also offload most complexity to the server alone, no longer requiring an additional OIDC library on the web client.

Also silent logout doesn't work on most IDPs for security reasons, one needs to actually redirect the user over to the IDP, which then prompts them once more if they actually want to log out.

This implementation should work with any OIDC-compliant IDP and even OAuth 2.0-only IDPs as long as they serve and OIDC discovery document.

[1] rfc-editor.org/rfc/rfc6749#section-5.1
2023-10-19 17:39:21 +05:00
Maksim Eltyshev
b9716c6e3a fix: OIDC finalization and refactoring 2023-10-17 19:18:19 +02:00
gorrilla10101
6941500c7b feat: OIDC with PKCE flow (#491) 2023-09-04 20:06:59 +05:00
dependabot[bot]
d260d2dac0 chore(deps): Bump json5 from 1.0.1 to 1.0.2 in /client (#370)
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](https://github.com/json5/json5/compare/v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-09 02:26:00 +05:00
Maksim Eltyshev
381146b991 fix: Fix router synchronization with redux store 2022-12-15 01:34:48 +01:00
Maksim Eltyshev
0dda762e99 fix: Improve building 2022-11-30 02:50:38 +01:00
Maksim Eltyshev
fa8afd7b6e chore: Update dependencies 2022-11-21 00:54:05 +01:00
Rafly Maulana
14434b81fe meta: Share global eslint config, move prettier config (#339) 2022-11-21 00:22:01 +05:00
Maksim Eltyshev
fa3a3ba2c0 ref: Little refactoring 2022-11-20 15:05:21 +01:00
Jacques Lorentz
2a64fc1a53 fix: Front-end base url with path (#303)
Closes #43, closes #111, closes #272
2022-09-30 14:48:58 +05:00
Maksim Eltyshev
e733a03c55 fix: Prevent popup from leaving window 2022-09-16 14:39:41 +05:00
Maksim Eltyshev
d0283aa89c fix: Use password strength estimator
Closes #294
2022-09-03 22:47:06 +05:00
SimonTagne
2b4c2b0f49 feat: Improve security of access tokens (#279)
Closes #275
2022-08-09 21:03:21 +05:00
Maksim Eltyshev
2f0eecaf2a chore: Update dependencies 2022-07-24 17:04:26 +02:00
Maksim Eltyshev
8f4d60c46f feat: Add gallery for attachments 2022-06-20 18:27:39 +02:00
ejo090
685cfe7cbe fix: Fix markdown line breaks
Closes #257
2022-06-06 17:37:43 +05:00
Maksim Eltyshev
7ef55ec578 feat: Store accessToken in cookies instead of localStorage 2022-04-26 18:01:55 +05:00
Maksim Eltyshev
411cfcabab Fix pre-commit hook, update dependencies 2022-04-19 02:52:19 +05:00
Maksim Eltyshev
47404265b0 Update dependencies 2022-04-16 00:08:14 +05:00
Maksim Eltyshev
921391ffcd Fix language loading. Closes #207 2022-03-31 02:23:44 +05:00
Maksim Eltyshev
99862c2f9a Update dependencies 2022-02-09 00:56:01 +05:00
Maksim Eltyshev
2130c04548 Fix board deletion, update dependencies. Closes #146 2021-08-02 17:23:56 +05:00
Maksim Eltyshev
fe91b5241e Project managers, board members, auto-update after reconnection, refactoring 2021-06-24 01:05:22 +05:00
Maksim Eltyshev
5cdb988948 Add support for GitHub Flavored Markdown. Closes #107 2021-03-25 21:32:31 +05:00
Maksim Eltyshev
560c2856e6 Fix file attach from clipboard when copy from browser. Closes #96 2021-03-20 03:33:16 +05:00
Maksim Eltyshev
5f2c24b428 Fix variables in update-card, update dependencies. Closes #85 2021-02-10 17:39:41 +05:00
Maksim Eltyshev
316f196eb5 Adjust label width, update dependencies. Closes #75 2021-01-09 18:42:16 +05:00
Maksim Eltyshev
9a2afb42f8 Update dependencies 2020-12-18 01:02:28 +05:00
Maksim Eltyshev
e2796195d8 Update dependencies 2020-11-20 06:01:42 +05:00
Maksim Eltyshev
76f9748e57 Update readme, update dependencies 2020-10-20 16:10:25 +05:00
Maksim Eltyshev
be9ab670f4 Update dependencies 2020-09-28 04:40:10 +05:00
Maksim Eltyshev
16acd1b49c Add test libs, update dependencies 2020-08-20 15:35:46 +05:00
Maksim Eltyshev
e7f4d7dfa6 Update dependencies 2020-08-11 20:45:35 +05:00
Maksim Eltyshev
30ed77af59 Prepare for collection board type, refactoring, update dependencies 2020-08-04 01:32:46 +05:00
Maksim Eltyshev
402645bc99 Add scrollbar for board tabs, update dependencies 2020-06-08 18:49:40 +05:00
Maksim Eltyshev
5bfff3865f Background gradients, migrate from CSS to SCSS, remove !important 2020-05-29 19:31:19 +05:00
Maksim Eltyshev
06f484dc72 Update dependencies 2020-05-26 14:10:06 +05:00
Maksim Eltyshev
c02bd16dd3 Update dependencies 2020-05-06 21:21:18 +05:00
Maksim Eltyshev
c2a16459df Fix Docker image, update dependencies 2020-04-29 04:50:32 +05:00
Maksim Eltyshev
d264382fda Add dropzone for attachment, paste attachment from clipboard 2020-04-28 19:46:55 +05:00
Maksim Eltyshev
202abacaec Fix language detection for some browsers 2020-04-11 01:02:08 +05:00
Maksim Eltyshev
fd707b6da5 Update dependencies 2020-04-10 00:24:05 +05:00
Maksim Eltyshev
de61d94a98 Update dependencies 2020-03-25 00:15:47 +05:00
Maksim Eltyshev
05adea1afd Update dependencies 2020-03-14 20:58:48 +05:00
Maksim Eltyshev
0d8a3d3752 Update dependencies 2020-02-25 02:10:27 +05:00
Maksim Eltyshev
45bde7e7c0 Move from prettier-eslint to eslint-plugin-prettier, update dependencies 2020-02-03 18:42:31 +05:00
Maksim Eltyshev
1f43d4f214 Update dependencies 2020-01-14 13:10:34 +05:00
Maksim Eltyshev
6ff86db58c Update dependencies 2019-12-30 04:24:06 +05:00
Maksim Eltyshev
2dbe98a1e5 Update dependencies 2019-12-11 04:23:33 +05:00
Maksim Eltyshev
ccb5aaf1e7 Update dependencies 2019-11-18 11:59:37 +05:00