feat(app): limit the docker API version supported by the frontend (#11855)

app/react/docker/proxy/queries/useServicePlugins.ts

@@ -10,13 +10,19 @@ import { EnvironmentId } from '@/react/portainer/environments/types';
 
 import { queryKeys } from '../../queries/utils/root';
 
-import { buildUrl } from './build-url';
+import { buildDockerProxyUrl } from './buildDockerProxyUrl';
 import { useInfo } from './useInfo';
 
+const pluginTypeToVersionMap: { [k in keyof PluginsInfo]: string } = {
+  Volume: 'docker.volumedriver/1.0',
+  Network: 'docker.networkdriver/1.0',
+  Log: 'docker.logdriver/1.0',
+};
+
 export async function getPlugins(environmentId: EnvironmentId) {
   try {
     const { data } = await axios.get<Array<Plugin>>(
-      buildUrl(environmentId, 'plugins')
+      buildDockerProxyUrl(environmentId, 'plugins')
     );
     return data;
   } catch (e) {
@@ -38,8 +44,7 @@ function usePlugins(
 export function useServicePlugins(
   environmentId: EnvironmentId,
   systemOnly: boolean,
-  pluginType: keyof PluginsInfo,
-  pluginVersion: string
+  pluginType: keyof PluginsInfo
 ) {
   const systemPluginsQuery = useInfo(environmentId, {
     select: (info) => info.Plugins,
@@ -47,70 +52,68 @@ export function useServicePlugins(
   const pluginsQuery = usePlugins(environmentId, { enabled: !systemOnly });
 
   return {
-    data: aggregateData(),
+    data: aggregateData(
+      systemPluginsQuery.data,
+      pluginsQuery.data,
+      systemOnly,
+      pluginType
+    ),
     isLoading: systemPluginsQuery.isLoading || pluginsQuery.isLoading,
   };
+}
 
-  function aggregateData() {
-    if (!systemPluginsQuery.data) {
-      return null;
-    }
-
-    const systemPlugins = systemPluginsQuery.data[pluginType] || [];
-
-    if (systemOnly) {
-      return systemPlugins;
-    }
-
-    const plugins =
-      pluginsQuery.data
-        ?.filter(
-          (plugin) =>
-            plugin.Enabled &&
-            // docker has an error in their types, so we need to cast to unknown first
-            // see https://docs.docker.com/engine/api/v1.41/#tag/Plugin/operation/PluginList
-            plugin.Config.Interface.Types.includes(
-              pluginVersion as unknown as PluginInterfaceType
-            )
-        )
-        .map((plugin) => plugin.Name) || [];
-
-    return [...systemPlugins, ...plugins];
+/**
+ * @private Exported only for AngularJS `PluginService` factory `app/docker/services/pluginService.js`
+ */
+export function aggregateData(
+  systemPluginsData: PluginsInfo | undefined,
+  pluginsData: Plugin[] | undefined,
+  systemOnly: boolean,
+  pluginType: keyof PluginsInfo
+) {
+  if (!systemPluginsData) {
+    return null;
   }
+
+  const systemPlugins = systemPluginsData[pluginType] || [];
+
+  if (systemOnly) {
+    return systemPlugins;
+  }
+
+  const plugins =
+    pluginsData
+      ?.filter(
+        (plugin) =>
+          plugin.Enabled &&
+          // docker has an error in their types, so we need to cast to unknown first
+          // see https://docs.docker.com/engine/api/v1.41/#tag/Plugin/operation/PluginList
+          plugin.Config.Interface.Types.includes(
+            pluginTypeToVersionMap[pluginType] as unknown as PluginInterfaceType
+          )
+      )
+      .map((plugin) => plugin.Name) || [];
+
+  return [...systemPlugins, ...plugins];
 }
 
 export function useLoggingPlugins(
   environmentId: EnvironmentId,
   systemOnly: boolean
 ) {
-  return useServicePlugins(
-    environmentId,
-    systemOnly,
-    'Log',
-    'docker.logdriver/1.0'
-  );
+  return useServicePlugins(environmentId, systemOnly, 'Log');
 }
 
 export function useVolumePlugins(
   environmentId: EnvironmentId,
   systemOnly: boolean
 ) {
-  return useServicePlugins(
-    environmentId,
-    systemOnly,
-    'Volume',
-    'docker.volumedriver/1.0'
-  );
+  return useServicePlugins(environmentId, systemOnly, 'Volume');
 }
 
 export function useNetworkPlugins(
   environmentId: EnvironmentId,
   systemOnly: boolean
 ) {
-  return useServicePlugins(
-    environmentId,
-    systemOnly,
-    'Network',
-    'docker.networkdriver/1.0'
-  );
+  return useServicePlugins(environmentId, systemOnly, 'Network');
 }