fix(settings): return the right value for public

app/portainer/views/users/edit/userController.js

@@ -123,7 +123,7 @@ angular.module('portainer.app').controller('UserController', [
           $scope.formValues.Administrator = user.Role === 1;
           $scope.formValues.username = user.Username;
           $scope.AuthenticationMethod = data.settings.AuthenticationMethod;
-          $scope.requiredPasswordLength = data.settings.InternalAuthSettings.RequiredPasswordLength;
+          $scope.requiredPasswordLength = data.settings.RequiredPasswordLength;
         })
         .catch(function error(err) {
           Notifications.error('Failure', err, 'Unable to retrieve user information');

app/portainer/views/users/usersController.js

@@ -121,7 +121,7 @@ angular.module('portainer.app').controller('UsersController', [
           users = assignAuthMethod(users, $scope.AuthenticationMethod);
           $scope.users = users;
           $scope.teams = _.orderBy(data.teams, 'Name', 'asc');
-          $scope.requiredPasswordLength = data.settings.InternalAuthSettings.RequiredPasswordLength;
+          $scope.requiredPasswordLength = data.settings.RequiredPasswordLength;
           $scope.teamSync = data.settings.TeamSync;
         })
         .catch(function error(err) {

app/react/portainer/environments/EdgeAutoCreateScriptView/AutomaticEdgeEnvCreation/AutomaticEdgeEnvCreation.tsx

@@ -99,7 +99,7 @@ export function AutomaticEdgeEnvCreation() {
               edgeKey={edgeKey}
               isLoading={edgeKeyMutation.isLoading}
               url={url}
-              tunnelUrl={settings?.Edge.TunnelServerAddress}
+              tunnelUrl={settings?.Edge?.TunnelServerAddress || ''}
             />
           </>
         )}
@@ -116,7 +116,7 @@ export function AutomaticEdgeEnvCreation() {
       settings &&
       settings.EnableEdgeComputeFeatures &&
       settings.EdgePortainerUrl &&
-      settings.Edge.TunnelServerAddress
+      settings.Edge?.TunnelServerAddress
     );
   }
 }

app/react/portainer/environments/wizard/EnvironmentsCreationView/shared/EdgeAgentTab/EdgeAgentForm/EdgeAgentForm.tsx

@@ -115,7 +115,7 @@ export function buildInitialValues(settings: Settings): FormValues {
     name: '',
     portainerUrl: settings.EdgePortainerUrl || buildApiUrlDefaultValue(),
     tunnelServerAddr:
-      settings.Edge.TunnelServerAddress || buildTunnelDefaultValue(),
+      settings.Edge?.TunnelServerAddress || buildTunnelDefaultValue(),
     pollFrequency: 0,
     meta: {
       groupId: 1,

app/react/portainer/settings/AuthenticationView/InternalAuth/InternalAuth.tsx

@@ -1,4 +1,4 @@
-import { Settings } from '@/react/portainer/settings/types';
+import { InternalAuthSettings } from '@/react/portainer/settings/types';
 
 import { confirmDestructive } from '@@/modals/confirm';
 import { FormSectionTitle } from '@@/form-components/FormSectionTitle';
@@ -10,7 +10,7 @@ import { SaveAuthSettingsButton } from './SaveAuthSettingsButton';
 export interface Props {
   onSaveSettings(): void;
   isLoading: boolean;
-  value: Settings['InternalAuthSettings'];
+  value: InternalAuthSettings;
   onChange(value: number): void;
 }
 

app/react/portainer/settings/EdgeComputeView/DeploymentSyncOptions/DeploymentSyncOptions.tsx

@@ -44,9 +44,9 @@ export function DeploymentSyncOptions() {
 
   const initialValues: FormValues = {
     Edge: {
-      CommandInterval: settingsQuery.data.Edge.CommandInterval,
-      PingInterval: settingsQuery.data.Edge.PingInterval,
-      SnapshotInterval: settingsQuery.data.Edge.SnapshotInterval,
+      CommandInterval: settingsQuery.data.Edge?.CommandInterval || 0,
+      PingInterval: settingsQuery.data.Edge?.PingInterval || 0,
+      SnapshotInterval: settingsQuery.data.Edge?.SnapshotInterval || 0,
     },
     EdgeAgentCheckinInterval: settingsQuery.data.EdgeAgentCheckinInterval,
   };

app/react/portainer/settings/EdgeComputeView/EdgeComputeSettings/EdgeComputeSettings.tsx

@@ -29,7 +29,7 @@ export function EdgeComputeSettings({ settings, onSubmit }: Props) {
     EnableEdgeComputeFeatures: settings.EnableEdgeComputeFeatures,
     EdgePortainerUrl: settings.EdgePortainerUrl,
     Edge: {
-      TunnelServerAddress: settings.Edge?.TunnelServerAddress,
+      TunnelServerAddress: settings.Edge?.TunnelServerAddress || '',
     },
     EnforceEdgeID: settings.EnforceEdgeID,
   };

app/react/portainer/settings/EdgeComputeView/EdgeComputeSettingsView.tsx

@@ -5,10 +5,11 @@ import { isBE } from '../../feature-flags/feature-flags.service';
 import { EdgeComputeSettings } from './EdgeComputeSettings';
 import { DeploymentSyncOptions } from './DeploymentSyncOptions/DeploymentSyncOptions';
 import { AutomaticEdgeEnvCreation } from './AutomaticEdgeEnvCreation';
+import { FormValues } from './EdgeComputeSettings/types';
 
 interface Props {
   settings: Settings;
-  onSubmit(values: Settings): void;
+  onSubmit(values: FormValues): void;
 }
 
 export function EdgeComputeSettingsView({ settings, onSubmit }: Props) {

app/react/portainer/settings/queries/useSettings.ts

@@ -40,7 +40,7 @@ interface AuthenticatedResponse extends PublicSettingsResponse {
 }
 
 interface EdgeAdminResponse extends AuthenticatedResponse {
-  Edge: EdgeSettings;
+  Edge?: EdgeSettings;
   /** TrustOnFirstConnect makes Portainer accepting edge agent connection by default */
   TrustOnFirstConnect: boolean;
   /** EnforceEdgeID makes Portainer store the Edge ID instead of accepting anyone */
@@ -53,12 +53,12 @@ interface EdgeAdminResponse extends AuthenticatedResponse {
 
 interface AdminResponse extends EdgeAdminResponse {
   /** A list of label name & value that will be used to hide containers when querying containers */
-  BlackListedLabels: Pair[];
-  LDAPSettings: LDAPSettings;
-  OAuthSettings: OAuthSettings;
-  InternalAuthSettings: InternalAuthSettings;
-  openAMTConfiguration: OpenAMTConfiguration;
-  fdoConfiguration: FDOConfiguration;
+  BlackListedLabels?: Pair[];
+  LDAPSettings?: LDAPSettings;
+  OAuthSettings?: OAuthSettings;
+  InternalAuthSettings?: InternalAuthSettings;
+  openAMTConfiguration?: OpenAMTConfiguration;
+  fdoConfiguration?: FDOConfiguration;
   /** The interval in which environment(endpoint) snapshots are created */
   SnapshotInterval: string;
   /** URL to the templates that will be displayed in the UI when navigating to App Templates */

app/react/portainer/settings/types.ts

@@ -125,13 +125,13 @@ export interface EdgeSettings {
 export interface Settings {
   LogoURL: string;
   CustomLoginBanner: string;
-  BlackListedLabels: Pair[];
+  BlackListedLabels?: Pair[];
   AuthenticationMethod: AuthenticationMethod;
-  InternalAuthSettings: InternalAuthSettings;
-  LDAPSettings: LDAPSettings;
-  OAuthSettings: OAuthSettings;
-  openAMTConfiguration: OpenAMTConfiguration;
-  fdoConfiguration: FDOConfiguration;
+  InternalAuthSettings?: InternalAuthSettings;
+  LDAPSettings?: LDAPSettings;
+  OAuthSettings?: OAuthSettings;
+  openAMTConfiguration?: OpenAMTConfiguration;
+  fdoConfiguration?: FDOConfiguration;
   Features: { [key: Feature]: boolean };
   SnapshotInterval: string;
   TemplatesURL: string;
@@ -149,7 +149,7 @@ export interface Settings {
   DefaultRegistry: DefaultRegistry;
   ExperimentalFeatures?: ExperimentalFeatures;
   GlobalDeploymentOptions?: GlobalDeploymentOptions;
-  Edge: EdgeSettings;
+  Edge?: EdgeSettings;
 }
 
 export interface GlobalDeploymentOptions {