mirror of
https://github.com/portainer/portainer.git
synced 2025-07-19 13:29:41 +02:00
fix(kube): correctly extract namespace from namespace manifest [EE-6555] (#11676)
Some checks are pending
ci / build_images (map[arch:amd64 platform:linux version:]) (push) Waiting to run
ci / build_images (map[arch:amd64 platform:windows version:1809]) (push) Waiting to run
ci / build_images (map[arch:amd64 platform:windows version:ltsc2022]) (push) Waiting to run
ci / build_images (map[arch:arm platform:linux version:]) (push) Waiting to run
ci / build_images (map[arch:arm64 platform:linux version:]) (push) Waiting to run
ci / build_images (map[arch:ppc64le platform:linux version:]) (push) Waiting to run
ci / build_images (map[arch:s390x platform:linux version:]) (push) Waiting to run
ci / build_manifests (push) Blocked by required conditions
/ triage (push) Waiting to run
Lint / Run linters (push) Waiting to run
Test / test-client (push) Waiting to run
Test / test-server (map[arch:amd64 platform:linux]) (push) Waiting to run
Test / test-server (map[arch:amd64 platform:windows version:1809]) (push) Waiting to run
Test / test-server (map[arch:amd64 platform:windows version:ltsc2022]) (push) Waiting to run
Test / test-server (map[arch:arm64 platform:linux]) (push) Waiting to run
Some checks are pending
ci / build_images (map[arch:amd64 platform:linux version:]) (push) Waiting to run
ci / build_images (map[arch:amd64 platform:windows version:1809]) (push) Waiting to run
ci / build_images (map[arch:amd64 platform:windows version:ltsc2022]) (push) Waiting to run
ci / build_images (map[arch:arm platform:linux version:]) (push) Waiting to run
ci / build_images (map[arch:arm64 platform:linux version:]) (push) Waiting to run
ci / build_images (map[arch:ppc64le platform:linux version:]) (push) Waiting to run
ci / build_images (map[arch:s390x platform:linux version:]) (push) Waiting to run
ci / build_manifests (push) Blocked by required conditions
/ triage (push) Waiting to run
Lint / Run linters (push) Waiting to run
Test / test-client (push) Waiting to run
Test / test-server (map[arch:amd64 platform:linux]) (push) Waiting to run
Test / test-server (map[arch:amd64 platform:windows version:1809]) (push) Waiting to run
Test / test-server (map[arch:amd64 platform:windows version:ltsc2022]) (push) Waiting to run
Test / test-server (map[arch:arm64 platform:linux]) (push) Waiting to run
Co-authored-by: Prabhat Khera <prabhat.khera@portainer.io>
This commit is contained in:
parent
a45ec9a7b4
commit
88ee1b5d19
2 changed files with 20 additions and 5 deletions
|
@ -125,12 +125,27 @@ func GetNamespace(manifestYaml []byte) (string, error) {
|
||||||
return "", errors.Wrap(err, "failed to unmarshal yaml manifest when obtaining namespace")
|
return "", errors.Wrap(err, "failed to unmarshal yaml manifest when obtaining namespace")
|
||||||
}
|
}
|
||||||
|
|
||||||
if _, ok := m["metadata"]; ok {
|
kind, ok := m["kind"].(string)
|
||||||
if namespace, ok := m["metadata"].(map[string]interface{})["namespace"]; ok {
|
if !ok {
|
||||||
return namespace.(string), nil
|
return "", errors.New("invalid kubernetes manifest, missing 'kind' field")
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if _, ok := m["metadata"]; ok {
|
||||||
|
var namespace interface{}
|
||||||
|
var ok bool
|
||||||
|
if strings.EqualFold(kind, "namespace") {
|
||||||
|
namespace, ok = m["metadata"].(map[string]interface{})["name"]
|
||||||
|
} else {
|
||||||
|
namespace, ok = m["metadata"].(map[string]interface{})["namespace"]
|
||||||
|
}
|
||||||
|
|
||||||
|
if ok {
|
||||||
|
if v, ok := namespace.(string); ok {
|
||||||
|
return v, nil
|
||||||
|
}
|
||||||
|
return "", errors.New("invalid kubernetes manifest, 'namespace' field is not a string")
|
||||||
|
}
|
||||||
|
}
|
||||||
return "", nil
|
return "", nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -648,7 +648,7 @@ func Test_GetNamespace(t *testing.T) {
|
||||||
input: `apiVersion: v1
|
input: `apiVersion: v1
|
||||||
kind: Namespace
|
kind: Namespace
|
||||||
metadata:
|
metadata:
|
||||||
namespace: test-namespace
|
name: test-namespace
|
||||||
`,
|
`,
|
||||||
want: "test-namespace",
|
want: "test-namespace",
|
||||||
},
|
},
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue