From 9044b25a235b1d96699d02cd4975b9f070537ec7 Mon Sep 17 00:00:00 2001 From: LP B Date: Wed, 22 Jan 2025 17:40:21 +0100 Subject: [PATCH] fix(app): remove passwords from registries list response (#334) --- api/http/handler/registries/registry_list.go | 4 ++++ app/react/portainer/registries/types/registry.ts | 1 - .../portainer/registries/utils/findRegistryMatch.test.ts | 1 - 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/api/http/handler/registries/registry_list.go b/api/http/handler/registries/registry_list.go index ee3a9dd45..eecb75168 100644 --- a/api/http/handler/registries/registry_list.go +++ b/api/http/handler/registries/registry_list.go @@ -36,5 +36,9 @@ func (handler *Handler) registryList(w http.ResponseWriter, r *http.Request) *ht return httperror.InternalServerError("Unable to retrieve registries from the database", err) } + for idx := range registries { + hideFields(®istries[idx], false) + } + return response.JSON(w, registries) } diff --git a/app/react/portainer/registries/types/registry.ts b/app/react/portainer/registries/types/registry.ts index 34c6d2e09..9b84ed5bf 100644 --- a/app/react/portainer/registries/types/registry.ts +++ b/app/react/portainer/registries/types/registry.ts @@ -70,7 +70,6 @@ export interface Registry { BaseURL: string; Authentication: boolean; Username: string; - Password?: string; RegistryAccesses: RegistryAccesses | null; Gitlab: Gitlab; Quay: Quay; diff --git a/app/react/portainer/registries/utils/findRegistryMatch.test.ts b/app/react/portainer/registries/utils/findRegistryMatch.test.ts index 7b976df44..af3c9f3b7 100644 --- a/app/react/portainer/registries/utils/findRegistryMatch.test.ts +++ b/app/react/portainer/registries/utils/findRegistryMatch.test.ts @@ -15,7 +15,6 @@ function buildTestRegistry( Name: name, Username: '', Authentication: false, - Password: '', BaseURL: '', Ecr: { Region: '' }, Github: { OrganisationName: '', UseOrganisation: false },