From a4739f17016c4f60d8d980b6cf9c4665acba45b9 Mon Sep 17 00:00:00 2001
From: Prabhat Khera <91852476+prabhat-org@users.noreply.github.com>
Date: Fri, 19 Jan 2024 12:14:47 +1300
Subject: [PATCH] fix messaging for resourse over commit (#10974)

---
 .../ConfigureForm/ConfigureForm.tsx           | 29 ++++++++++++-------
 1 file changed, 18 insertions(+), 11 deletions(-)

diff --git a/app/react/kubernetes/cluster/ConfigureView/ConfigureForm/ConfigureForm.tsx b/app/react/kubernetes/cluster/ConfigureView/ConfigureForm/ConfigureForm.tsx
index 6ce089635..faed26766 100644
--- a/app/react/kubernetes/cluster/ConfigureView/ConfigureForm/ConfigureForm.tsx
+++ b/app/react/kubernetes/cluster/ConfigureView/ConfigureForm/ConfigureForm.tsx
@@ -19,6 +19,7 @@ import { FormActions } from '@@/form-components/FormActions';
 import { confirm } from '@@/modals/confirm';
 import { ModalType } from '@@/modals';
 import { buildConfirmButton } from '@@/modals/utils';
+import { InsightsBox } from '@@/InsightsBox';
 
 import { useIngressControllerClassMapQuery } from '../../ingressClass/useIngressControllerClassMap';
 import { IngressControllerClassMap } from '../../ingressClass/types';
@@ -284,29 +285,35 @@ function InnerForm({
           </div>
         </FormSection>
         <FormSection title="Resources and Metrics">
-          <TextTip color="orange">
-            <p>
-              By ENABLING resource over-commit, you are able to assign more
-              resources to namespaces than is physically available in the
-              cluster. This may lead to unexpected deployment failures if there
-              is insufficient resource to service demand.
-            </p>
-          </TextTip>
+          <InsightsBox
+            insightCloseId="resourceOverCommit"
+            className="mb-4"
+            header="Allow resource over-commit - UI-only change in 2.20"
+            content="Resource over-commit has always been ENABLED in Portainer CE. However, the toggle was incorrectly shown as OFF. This has now been corrected but please note that no functionality has been removed."
+          />
           <TextTip color="blue">
             <p>
-              By DISABLING resource over-commit (highly recommended), you are
-              only able to assign resources to namespaces that are less (in
+              By DISABLING resource over-commit (highly recommended), you can
+              ONLY assign namespaces CPU and memory resources that are less (in
               aggregate) than the cluster total minus any system resource
               reservation.
             </p>
           </TextTip>
+          <TextTip color="orange">
+            <p>
+              By ENABLING resource over-commit, you can assign namespaces more
+              resources than are physically available in the cluster. This may
+              lead to unexpected deployment failures if there are insufficient
+              resources to service demand.
+            </p>
+          </TextTip>
           <div className="form-group">
             <div className="col-sm-12">
               <SwitchField
                 label="Allow resource over-commit"
                 labelClass="col-sm-5 col-lg-4"
                 name="resourceOverCommitPercentage"
-                checked={values.enableResourceOverCommit}
+                checked
                 featureId={FeatureId.K8S_SETUP_DEFAULT}
                 onChange={(checked: boolean) => {
                   setFieldValue('enableResourceOverCommit', checked);