refactor(api): use a standard stack identifier (#1980)

api/bolt/migrate_dbversion11.go

@@ -1,6 +1,13 @@
 package bolt
 
-import "github.com/portainer/portainer"
+import (
+	"strconv"
+	"strings"
+
+	"github.com/boltdb/bolt"
+	"github.com/portainer/portainer"
+	"github.com/portainer/portainer/bolt/internal"
+)
 
 func (m *Migrator) updateEndpointsToVersion12() error {
 	legacyEndpoints, err := m.EndpointService.Endpoints()
@@ -38,16 +45,24 @@ func (m *Migrator) updateEndpointGroupsToVersion12() error {
 	return nil
 }
 
+type legacyStack struct {
+	ID          string               `json:"Id"`
+	Name        string               `json:"Name"`
+	EndpointID  portainer.EndpointID `json:"EndpointId"`
+	SwarmID     string               `json:"SwarmId"`
+	EntryPoint  string               `json:"EntryPoint"`
+	Env         []portainer.Pair     `json:"Env"`
+	ProjectPath string
+}
+
 func (m *Migrator) updateStacksToVersion12() error {
-	legacyStacks, err := m.StackService.Stacks()
+	legacyStacks, err := m.retrieveLegacyStacks()
 	if err != nil {
 		return err
 	}
 
-	for _, stack := range legacyStacks {
-		stack.Type = portainer.DockerSwarmStack
-
-		err = m.StackService.UpdateStack(stack.ID, &stack)
+	for _, legacyStack := range legacyStacks {
+		err := m.convertLegacyStack(&legacyStack)
 		if err != nil {
 			return err
 		}
@@ -55,3 +70,64 @@ func (m *Migrator) updateStacksToVersion12() error {
 
 	return nil
 }
+
+func (m *Migrator) convertLegacyStack(s *legacyStack) error {
+	stackID := m.StackService.GetNextIdentifier()
+	stack := &portainer.Stack{
+		ID:         portainer.StackID(stackID),
+		Name:       s.Name,
+		Type:       portainer.DockerSwarmStack,
+		SwarmID:    s.SwarmID,
+		EndpointID: 0,
+		EntryPoint: s.EntryPoint,
+		Env:        s.Env,
+	}
+
+	stack.ProjectPath = strings.Replace(s.ProjectPath, s.ID, strconv.Itoa(stackID), 1)
+	err := m.store.FileService.Rename(s.ProjectPath, stack.ProjectPath)
+	if err != nil {
+		return err
+	}
+
+	err = m.deleteLegacyStack(s.ID)
+	if err != nil {
+		return err
+	}
+
+	return m.StackService.CreateStack(stack)
+}
+
+func (m *Migrator) deleteLegacyStack(legacyID string) error {
+	return m.store.db.Update(func(tx *bolt.Tx) error {
+		bucket := tx.Bucket([]byte(stackBucketName))
+		err := bucket.Delete([]byte(legacyID))
+		if err != nil {
+			return err
+		}
+		return nil
+	})
+}
+
+func (m *Migrator) retrieveLegacyStacks() ([]legacyStack, error) {
+	var legacyStacks = make([]legacyStack, 0)
+	err := m.store.db.View(func(tx *bolt.Tx) error {
+		bucket := tx.Bucket([]byte(stackBucketName))
+		cursor := bucket.Cursor()
+
+		for k, v := cursor.First(); k != nil; k, v = cursor.Next() {
+			var stack legacyStack
+			err := internal.UnmarshalObject(v, &stack)
+			if err != nil {
+				return err
+			}
+			legacyStacks = append(legacyStacks, stack)
+		}
+
+		return nil
+	})
+	if err != nil {
+		return nil, err
+	}
+
+	return legacyStacks, nil
+}