diff --git a/app/docker/components/imageRegistry/porImageRegistryController.js b/app/docker/components/imageRegistry/porImageRegistryController.js index 721d61afe..06b10c0b9 100644 --- a/app/docker/components/imageRegistry/porImageRegistryController.js +++ b/app/docker/components/imageRegistry/porImageRegistryController.js @@ -15,9 +15,11 @@ class porImageRegistryController { async onInit() { try { - const [registries, dockerhub, availableImages] = await Promise.all([this.RegistryService.registries(), - this.DockerHubService.dockerhub(), - this.autoComplete ? this.ImageService.images() : []]); + const [registries, dockerhub, availableImages] = await Promise.all([ + this.RegistryService.registries(), + this.DockerHubService.dockerhub(), + this.autoComplete ? this.ImageService.images() : [] + ]); this.availableImages = this.ImageService.getUniqueTagListFromImages(availableImages); this.availableRegistries = [dockerhub].concat(registries); diff --git a/app/docker/services/imageService.js b/app/docker/services/imageService.js index fbab095f2..ae818c710 100644 --- a/app/docker/services/imageService.js +++ b/app/docker/services/imageService.js @@ -135,8 +135,6 @@ angular.module('portainer.docker') * @param {bool} ignoreErrors */ function pullImage(registry, ignoreErrors) { - // var imageDetails = ImageHelper.extractImageAndRegistryFromRepository(image); - // var imageConfiguration = ImageHelper.createImageConfigForContainer(imageDetails.image, registry.URL); var authenticationDetails = registry.Registry.Authentication ? RegistryService.encodedCredentials(registry.Registry) : ''; HttpRequestHelper.setRegistryAuthenticationHeader(authenticationDetails); diff --git a/app/docker/views/containers/create/createContainerController.js b/app/docker/views/containers/create/createContainerController.js index 5f52657eb..ce5719b1a 100644 --- a/app/docker/views/containers/create/createContainerController.js +++ b/app/docker/views/containers/create/createContainerController.js @@ -131,7 +131,6 @@ function ($q, $scope, $async, $state, $timeout, $transition$, $filter, Container $scope.fromContainerMultipleNetworks = false; - // TODO function prepareImageConfig(config) { const imageConfig = ImageHelper.createImageConfigForContainer($scope.formValues.RegistryModel); config.Image = imageConfig.fromImage; @@ -436,15 +435,10 @@ function ($q, $scope, $async, $state, $timeout, $transition$, $filter, Container $scope.config.HostConfig.Devices = path; } - // TODO function loadFromContainerImageConfig() { - var imageInfo = ImageHelper.extractImageAndRegistryFromRepository($scope.config.Image); - RegistryService.retrieveRegistryFromRepository($scope.config.Image) - .then(function success(data) { - if (data) { - $scope.config.Image = imageInfo.image; - $scope.formValues.RegistryModel = data; - } + RegistryService.retrievePorRegistryModelFromRepository($scope.config.Image) + .then((model) => { + $scope.formValues.RegistryModel = model; }) .catch(function error(err) { Notifications.error('Failure', err, 'Unable to retrive registry'); diff --git a/app/docker/views/containers/create/createcontainer.html b/app/docker/views/containers/create/createcontainer.html index cec1a551e..ec3e77e14 100644 --- a/app/docker/views/containers/create/createcontainer.html +++ b/app/docker/views/containers/create/createcontainer.html @@ -33,6 +33,16 @@ auto-complete="true" label-class="col-sm-1" input-class="col-sm-11 col-md-5" > +