From c559b6b55cb14d8b11b485abad3ffff58e47e6cb Mon Sep 17 00:00:00 2001 From: George Cheng Date: Fri, 1 Nov 2019 11:15:33 +0800 Subject: [PATCH] fix(container-creation): Fix bad env in container creation (#2996) Currently we are using RegExp `/\=(.+)/` to catch key-value of environment variables, which could not match empty-value environment variables such as `KEY=`. This commit will change the RegExp to `/\=(.*)/`, which matches the empty values. --- app/docker/views/containers/create/createContainerController.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/docker/views/containers/create/createContainerController.js b/app/docker/views/containers/create/createContainerController.js index fe41674a6..e8e48c083 100644 --- a/app/docker/views/containers/create/createContainerController.js +++ b/app/docker/views/containers/create/createContainerController.js @@ -393,7 +393,7 @@ function ($q, $scope, $async, $state, $timeout, $transition$, $filter, Container var envArr = []; for (var e in $scope.config.Env) { if ({}.hasOwnProperty.call($scope.config.Env, e)) { - var arr = $scope.config.Env[e].split(/\=(.+)/); + var arr = $scope.config.Env[e].split(/\=(.*)/); envArr.push({'name': arr[0], 'value': arr[1]}); } }