From cb9fe2606cffdc4fde57c1ef6c56de704e974032 Mon Sep 17 00:00:00 2001
From: Oscar Zhou <100548325+oscarzhou-portainer@users.noreply.github.com>
Date: Tue, 25 Oct 2022 14:39:24 +1300
Subject: [PATCH] fix(team): disable team leader setting when external auth
 sync is enabled [EE-3579] (#7852)

---
 app/portainer/react/components/index.ts         |  1 +
 app/portainer/views/users/users.html            | 11 +++++++++++
 app/portainer/views/users/usersController.js    |  1 +
 .../components/TeamsSelector/TeamsSelector.tsx  |  3 +++
 .../components/UsersSelector/UsersSelector.tsx  |  3 +++
 .../ListView/CreateTeamForm/CreateTeamForm.tsx  | 17 +++++++++++++++++
 6 files changed, 36 insertions(+)

diff --git a/app/portainer/react/components/index.ts b/app/portainer/react/components/index.ts
index fd11fb321..14eeff6f0 100644
--- a/app/portainer/react/components/index.ts
+++ b/app/portainer/react/components/index.ts
@@ -147,6 +147,7 @@ export const componentsModule = angular
       'name',
       'placeholder',
       'teams',
+      'disabled',
     ])
   )
   .component(
diff --git a/app/portainer/views/users/users.html b/app/portainer/views/users/users.html
index 97422fd2c..30a148024 100644
--- a/app/portainer/views/users/users.html
+++ b/app/portainer/views/users/users.html
@@ -118,9 +118,20 @@
                 data-cy="'user-teamSelect'"
                 on-change="(onChangeTeamIds)"
                 input-id="'teams-selector'"
+                disabled="teamSync"
               ></teams-selector>
             </div>
           </div>
+          <div class="form-group" ng-if="teamSync">
+            <div class="col-sm-12">
+              <span class="small">
+                <p class="small text-muted vertical-center">
+                  <pr-icon icon="'alert-circle'" feather="true" class-name="'icon-warning =vertical-center'"></pr-icon>
+                  The team leader feature is disabled as external authentication is currently enabled with team sync.
+                </p>
+              </span>
+            </div>
+          </div>
           <!-- !teams -->
           <div class="form-group" ng-if="isAdmin && !formValues.Administrator && formValues.Teams.length === 0">
             <div class="col-sm-12">
diff --git a/app/portainer/views/users/usersController.js b/app/portainer/views/users/usersController.js
index d3a35547c..bd326a767 100644
--- a/app/portainer/views/users/usersController.js
+++ b/app/portainer/views/users/usersController.js
@@ -131,6 +131,7 @@ angular.module('portainer.app').controller('UsersController', [
           $scope.teams = _.orderBy(data.teams, 'Name', 'asc');
           $scope.AuthenticationMethod = data.settings.AuthenticationMethod;
           $scope.requiredPasswordLength = data.settings.RequiredPasswordLength;
+          $scope.teamSync = data.settings.TeamSync;
         })
         .catch(function error(err) {
           Notifications.error('Failure', err, 'Unable to retrieve users and teams');
diff --git a/app/react/components/TeamsSelector/TeamsSelector.tsx b/app/react/components/TeamsSelector/TeamsSelector.tsx
index b19532140..0158b8b06 100644
--- a/app/react/components/TeamsSelector/TeamsSelector.tsx
+++ b/app/react/components/TeamsSelector/TeamsSelector.tsx
@@ -10,6 +10,7 @@ interface Props {
   dataCy?: string;
   inputId?: string;
   placeholder?: string;
+  disabled?: boolean;
 }
 
 export function TeamsSelector({
@@ -20,6 +21,7 @@ export function TeamsSelector({
   dataCy,
   inputId,
   placeholder,
+  disabled,
 }: Props) {
   const options = teams.map((team) => ({ label: team.Name, value: team.Id }));
 
@@ -33,6 +35,7 @@ export function TeamsSelector({
       data-cy={dataCy}
       inputId={inputId}
       placeholder={placeholder}
+      disabled={disabled}
     />
   );
 }
diff --git a/app/react/components/UsersSelector/UsersSelector.tsx b/app/react/components/UsersSelector/UsersSelector.tsx
index 2963830e8..4edb68028 100644
--- a/app/react/components/UsersSelector/UsersSelector.tsx
+++ b/app/react/components/UsersSelector/UsersSelector.tsx
@@ -10,6 +10,7 @@ interface Props {
   dataCy?: string;
   inputId?: string;
   placeholder?: string;
+  disabled?: boolean;
 }
 
 export function UsersSelector({
@@ -20,6 +21,7 @@ export function UsersSelector({
   dataCy,
   inputId,
   placeholder,
+  disabled,
 }: Props) {
   return (
     <Select
@@ -36,6 +38,7 @@ export function UsersSelector({
       data-cy={dataCy}
       inputId={inputId}
       placeholder={placeholder}
+      isDisabled={disabled}
     />
   );
 }
diff --git a/app/react/portainer/users/teams/ListView/CreateTeamForm/CreateTeamForm.tsx b/app/react/portainer/users/teams/ListView/CreateTeamForm/CreateTeamForm.tsx
index 662ad32d5..a13619ce5 100644
--- a/app/react/portainer/users/teams/ListView/CreateTeamForm/CreateTeamForm.tsx
+++ b/app/react/portainer/users/teams/ListView/CreateTeamForm/CreateTeamForm.tsx
@@ -5,12 +5,14 @@ import { useReducer } from 'react';
 import { Icon } from '@/react/components/Icon';
 import { User } from '@/portainer/users/types';
 import { notifySuccess } from '@/portainer/services/notifications';
+import { usePublicSettings } from '@/react/portainer/settings/queries';
 
 import { FormControl } from '@@/form-components/FormControl';
 import { Widget } from '@@/Widget';
 import { Input } from '@@/form-components/Input';
 import { UsersSelector } from '@@/UsersSelector';
 import { LoadingButton } from '@@/buttons/LoadingButton';
+import { TextTip } from '@@/Tip/TextTip';
 
 import { createTeam } from '../../teams.service';
 import { Team } from '../../types';
@@ -26,6 +28,9 @@ interface Props {
 export function CreateTeamForm({ users, teams }: Props) {
   const addTeamMutation = useAddTeamMutation();
   const [formKey, incFormKey] = useReducer((state: number) => state + 1, 0);
+  const teamSyncQuery = usePublicSettings<boolean>({
+    select: (settings) => settings.TeamSync,
+  });
 
   const initialValues = {
     name: '',
@@ -95,10 +100,22 @@ export function CreateTeamForm({ users, teams }: Props) {
                         dataCy="team-teamLeaderSelect"
                         inputId="users-input"
                         placeholder="Select one or more team leaders"
+                        disabled={teamSyncQuery.data}
                       />
                     </FormControl>
                   )}
 
+                  {teamSyncQuery.data && (
+                    <div className="form-group">
+                      <div className="col-sm-12">
+                        <TextTip color="orange">
+                          The team leader feature is disabled as external
+                          authentication is currently enabled with team sync.
+                        </TextTip>
+                      </div>
+                    </div>
+                  )}
+
                   <div className="form-group">
                     <div className="col-sm-12">
                       <LoadingButton