Docker/portainer
Docker/portainer
1
0
Fork 0
mirror of https://github.com/portainer/portainer.git synced 2025-08-06 14:25:31 +02:00
Code Issues Releases Activity

fix(linter): add linter rules to reduce the chance for invalid FIPS settings BE-11979 (#975)

Browse source
This commit is contained in:
andres-portainer 2025-08-05 09:23:07 -03:00 • committed by GitHub
parent dc273b2d63
commit d00d71ecbf
13 changed files with 140 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

5
api/http/handler/websocket/proxy.go
View file

@ -73,10 +73,7 @@ func (handler *Handler) doProxyWebsocketRequest(
proxy.Dialer = &proxyDialer
if enableTLS {
tlsConfig := crypto.CreateTLSConfiguration()
tlsConfig.InsecureSkipVerify = params.endpoint.TLSConfig.TLSSkipVerify
proxyDialer.TLSClientConfig = tlsConfig
proxyDialer.TLSClientConfig = crypto.CreateTLSConfiguration(params.endpoint.TLSConfig.TLSSkipVerify)
}
signature, err := handler.SignatureService.CreateSignature(portainer.PortainerAgentSignatureMessage)

2
api/http/proxy/factory/kubernetes/local_transport_test.go
View file

@ -9,5 +9,5 @@ import (
func TestNewLocalTransport(t *testing.T) {
transport, err := NewLocalTransport(nil, nil, nil, nil, nil)
require.NoError(t, err)
require.True(t, transport.baseTransport.httpTransport.TLSClientConfig.InsecureSkipVerify)
require.True(t, transport.baseTransport.httpTransport.TLSClientConfig.InsecureSkipVerify) //nolint:forbidigo
}

2
api/http/server.go
View file

@ -372,7 +372,7 @@ func (server *Server) Start() error {
TLSNextProto: make(map[string]func(*http.Server, *tls.Conn, http.Handler)), // Disable HTTP/2
}
httpsServer.TLSConfig = crypto.CreateTLSConfiguration()
httpsServer.TLSConfig = crypto.CreateTLSConfiguration(false)
httpsServer.TLSConfig.GetCertificate = func(*tls.ClientHelloInfo) (*tls.Certificate, error) {
return server.SSLService.GetRawCertificate(), nil
}