Docker/portainer
Docker/portainer
1
0
Fork 0
mirror of https://github.com/portainer/portainer.git synced 2025-07-22 23:09:41 +02:00
Code Issues Releases Activity

fix(image-details): fix the ability to pull an image from a tag (#878)

Browse source
This commit is contained in:
Anthony Lapenna 2017-05-23 20:25:56 +02:00 • committed by GitHub
parent 6834c20b5d
commit d3ecf1d7a8
3 changed files with 64 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

18
app/components/image/imageController.js
View file

@ -17,7 +17,7 @@ function ($scope, $stateParams, $state, ImageService, Notifications) {
$state.go('image', {id: $stateParams.id}, {reload: true});
})
.catch(function error(err) {
Notifications.error("Failure", err, "Unable to tag image");
Notifications.error('Failure', err, 'Unable to tag image');
})
.finally(function final() {
$('#loadingViewSpinner').hide();
@ -31,7 +31,7 @@ function ($scope, $stateParams, $state, ImageService, Notifications) {
Notifications.success('Image successfully pushed');
})
.catch(function error(err) {
Notifications.error("Failure", err, "Unable to push image tag");
Notifications.error('Failure', err, 'Unable to push image tag');
})
.finally(function final() {
$('#loadingViewSpinner').hide();
@ -40,15 +40,13 @@ function ($scope, $stateParams, $state, ImageService, Notifications) {
$scope.pullImage = function(tag) {
$('#loadingViewSpinner').show();
var image = $scope.config.Image;
var registry = $scope.config.Registry;
ImageService.pullImage(image, registry)
ImageService.pullTag(tag)
.then(function success(data) {
Notifications.success('Image successfully pulled', image);
Notifications.success('Image successfully pulled', tag);
})
.catch(function error(err){
Notifications.error("Failure", err, "Unable to pull image");
Notifications.error('Failure', err, 'Unable to pull image');
})
.finally(function final() {
$('#loadingViewSpinner').hide();
@ -68,7 +66,7 @@ function ($scope, $stateParams, $state, ImageService, Notifications) {
}
})
.catch(function error(err) {
Notifications.error("Failure", err, 'Unable to remove image');
Notifications.error('Failure', err, 'Unable to remove image');
})
.finally(function final() {
$('#loadingViewSpinner').hide();
@ -83,7 +81,7 @@ function ($scope, $stateParams, $state, ImageService, Notifications) {
$state.go('images', {}, {reload: true});
})
.catch(function error(err) {
Notifications.error("Failure", err, 'Unable to remove image');
Notifications.error('Failure', err, 'Unable to remove image');
})
.finally(function final() {
$('#loadingViewSpinner').hide();
@ -97,7 +95,7 @@ function ($scope, $stateParams, $state, ImageService, Notifications) {
$scope.image = data;
})
.catch(function error(err) {
Notifications.error("Failure", err, "Unable to retrieve image details");
Notifications.error('Failure', err, 'Unable to retrieve image details');
$state.go('images');
})
.finally(function final() {